feat(updater): allow passing headers & timeout in Update.download* methods (#1661)

closes #1634

Author: amrbashir

.changes/updater-js-headers-download.md

@@ -0,0 +1,5 @@
+---
+"updater-js": "patch"
+---
+
+Add a second argument in `Update.download` and `Update.donloadAndInstall` JS APIs to modify headers and timeout when downloading the update.

plugins/updater/api-iife.js

@@ -4,14 +4,14 @@
 
 import { invoke, Channel, Resource } from "@tauri-apps/api/core";
 
-/** Options used to check for updates */
+/** Options used when checking for updates */
 interface CheckOptions {
   /**
    * Request headers
    */
   headers?: HeadersInit;
   /**
-   * Timeout in seconds
+   * Timeout in milliseconds
    */
   timeout?: number;
   /**
@@ -24,6 +24,18 @@ interface CheckOptions {
   target?: string;
 }
 
+/** Options used when downloading an update */
+interface DownloadOptions {
+  /**
+   * Request headers
+   */
+  headers?: HeadersInit;
+  /**
+   * Timeout in milliseconds
+   */
+  timeout?: number;
+}
+
 interface UpdateMetadata {
   rid: number;
   available: boolean;
@@ -57,14 +69,18 @@ class Update extends Resource {
   }
 
   /** Download the updater package */
-  async download(onEvent?: (progress: DownloadEvent) => void): Promise<void> {
+  async download(
+    onEvent?: (progress: DownloadEvent) => void,
+    options?: DownloadOptions,
+  ): Promise<void> {
     const channel = new Channel<DownloadEvent>();
     if (onEvent) {
       channel.onmessage = onEvent;
     }
     const downloadedBytesRid = await invoke<number>("plugin:updater|download", {
       onEvent: channel,
       rid: this.rid,
+      ...options,
     });
     this.downloadedBytes = new Resource(downloadedBytesRid);
   }
@@ -87,6 +103,7 @@ class Update extends Resource {
   /** Downloads the updater package and installs it */
   async downloadAndInstall(
     onEvent?: (progress: DownloadEvent) => void,
+    options?: DownloadOptions,
   ): Promise<void> {
     const channel = new Channel<DownloadEvent>();
     if (onEvent) {
@@ -95,6 +112,7 @@ class Update extends Resource {
     await invoke("plugin:updater|download_and_install", {
       onEvent: channel,
       rid: this.rid,
+      ...options,
     });
   }
 
@@ -115,5 +133,5 @@ async function check(options?: CheckOptions): Promise<Update | null> {
   }).then((meta) => (meta.available ? new Update(meta) : null));
 }
 
-export type { CheckOptions, DownloadEvent };
+export type { CheckOptions, DownloadOptions, DownloadEvent };
 export { check, Update };

plugins/updater/guest-js/index.ts

@@ -4,10 +4,11 @@
 
 use crate::{Result, Update, UpdaterExt};
 
+use http::{HeaderMap, HeaderName, HeaderValue};
 use serde::Serialize;
 use tauri::{ipc::Channel, Manager, Resource, ResourceId, Runtime, Webview};
 
-use std::time::Duration;
+use std::{str::FromStr, time::Duration};
 use url::Url;
 
 #[derive(Debug, Clone, Serialize)]
@@ -53,7 +54,7 @@ pub(crate) async fn check<R: Runtime>(
         }
     }
     if let Some(timeout) = timeout {
-        builder = builder.timeout(Duration::from_secs(timeout));
+        builder = builder.timeout(Duration::from_millis(timeout));
     }
     if let Some(ref proxy) = proxy {
         let url = Url::parse(proxy.as_str())?;
@@ -83,8 +84,25 @@ pub(crate) async fn download<R: Runtime>(
     webview: Webview<R>,
     rid: ResourceId,
     on_event: Channel<DownloadEvent>,
+    headers: Option<Vec<(String, String)>>,
+    timeout: Option<u64>,
 ) -> Result<ResourceId> {
     let update = webview.resources_table().get::<Update>(rid)?;
+
+    let mut update = (*update).clone();
+
+    if let Some(headers) = headers {
+        let mut map = HeaderMap::new();
+        for (k, v) in headers {
+            map.append(HeaderName::from_str(&k)?, HeaderValue::from_str(&v)?);
+        }
+        update.headers = map;
+    }
+
+    if let Some(timeout) = timeout {
+        update.timeout = Some(Duration::from_millis(timeout));
+    }
+
     let mut first_chunk = true;
     let bytes = update
         .download(
@@ -100,6 +118,7 @@ pub(crate) async fn download<R: Runtime>(
             },
         )
         .await?;
+
     Ok(webview.resources_table().add(DownloadedBytes(bytes)))
 }
 
@@ -123,9 +142,25 @@ pub(crate) async fn download_and_install<R: Runtime>(
     webview: Webview<R>,
     rid: ResourceId,
     on_event: Channel<DownloadEvent>,
+    headers: Option<Vec<(String, String)>>,
+    timeout: Option<u64>,
 ) -> Result<()> {
     let update = webview.resources_table().get::<Update>(rid)?;
 
+    let mut update = (*update).clone();
+
+    if let Some(headers) = headers {
+        let mut map = HeaderMap::new();
+        for (k, v) in headers {
+            map.append(HeaderName::from_str(&k)?, HeaderValue::from_str(&v)?);
+        }
+        update.headers = map;
+    }
+
+    if let Some(timeout) = timeout {
+        update.timeout = Some(Duration::from_millis(timeout));
+    }
+
     let mut first_chunk = true;
 
     update

plugins/updater/src/commands.rs

@@ -68,6 +68,10 @@ pub enum Error {
     #[error(transparent)]
     Http(#[from] http::Error),
     #[error(transparent)]
+    InvalidHeaderValue(#[from] http::header::InvalidHeaderValue),
+    #[error(transparent)]
+    InvalidHeaderName(#[from] http::header::InvalidHeaderName),
+    #[error(transparent)]
     Tauri(#[from] tauri::Error),
 }
 

plugins/updater/src/error.rs

@@ -469,10 +469,6 @@ impl Update {
             "Accept",
             HeaderValue::from_str("application/octet-stream").unwrap(),
         );
-        headers.insert(
-            "User-Agent",
-            HeaderValue::from_str("tauri-updater").unwrap(),
-        );
 
         let mut request = ClientBuilder::new().user_agent(UPDATER_USER_AGENT);
         if let Some(timeout) = self.timeout {