fix(updater): fix headers option in Updater.download (#2757)

Author: Legend-Master

.changes/updater-download-headers.md

@@ -0,0 +1,6 @@
+---
+"updater": patch
+"updater-js": patch
+---
+
+Fix headers option in `Update.download` and `Update.downloadAndInstall` doesn't work with `Record<string, string> | Headers` types

plugins/updater/api-iife.js

@@ -81,6 +81,7 @@ class Update extends Resource {
     onEvent?: (progress: DownloadEvent) => void,
     options?: DownloadOptions
   ): Promise<void> {
+    convertToRustHeaders(options)
     const channel = new Channel<DownloadEvent>()
     if (onEvent) {
       channel.onmessage = onEvent
@@ -113,6 +114,7 @@ class Update extends Resource {
     onEvent?: (progress: DownloadEvent) => void,
     options?: DownloadOptions
   ): Promise<void> {
+    convertToRustHeaders(options)
     const channel = new Channel<DownloadEvent>()
     if (onEvent) {
       channel.onmessage = onEvent
@@ -132,15 +134,22 @@ class Update extends Resource {
 
 /** Check for updates, resolves to `null` if no updates are available */
 async function check(options?: CheckOptions): Promise<Update | null> {
-  if (options?.headers) {
-    options.headers = Array.from(new Headers(options.headers).entries())
-  }
+  convertToRustHeaders(options)
 
   const metadata = await invoke<UpdateMetadata | null>('plugin:updater|check', {
     ...options
   })
   return metadata ? new Update(metadata) : null
 }
 
+/**
+ * Converts the headers in options to be an {@linkcode Array<[string, string]>} which is what the Rust side expects
+ */
+function convertToRustHeaders(options?: { headers?: HeadersInit }) {
+  if (options?.headers) {
+    options.headers = Array.from(new Headers(options.headers).entries())
+  }
+}
+
 export type { CheckOptions, DownloadOptions, DownloadEvent }
 export { check, Update }