Fix clippy warnings on nightly

Fix warnings:
- unused_variables
- clippy::if_then_panic
- clippy::or_fun_call
- clippy::for_kv_map
- clippy::needless_borrow

Silence warnings:
- clippy::match_single_binding
- clippy::new_without_default
- clippy::from_str_radix_10
- clippy::needless_range_loop

Signed-off-by: Tim Crawford <tcrawford@system76.com>

Author: crawfxrd

src/cmd/int.rs

@@ -10,7 +10,7 @@ pub fn int(ec: &mut Ec, args: &[&str]) {
         return;
     }
 
-    let int = match u8::from_str_radix(&args[0], 10) {
+    let int = match u8::from_str_radix(args[0], 10) {
         Ok(ok) => if ok <= 5 {
             ok
         } else {

src/cmd/kbc.rs

@@ -17,7 +17,7 @@ pub fn cmd(ec: &mut Ec, args: &[&str]) {
         return;
     }
 
-    let data = match u8::from_str_radix(&args[0], 16) {
+    let data = match u8::from_str_radix(args[0], 16) {
         Ok(ok) => ok,
         Err(err) => {
             eprintln!("argument '{}' failed to parse as hex: {}", args[0], err);
@@ -55,7 +55,7 @@ pub fn write(ec: &mut Ec, args: &[&str]) {
         return;
     }
 
-    let data = match u8::from_str_radix(&args[0], 16) {
+    let data = match u8::from_str_radix(args[0], 16) {
         Ok(ok) => ok,
         Err(err) => {
             eprintln!("argument '{}' failed to parse as hex: {}", args[0], err);

src/cmd/mod.rs

@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: MIT
 
+#![allow(clippy::from_str_radix_10)]
+
 pub mod int;
 pub mod kbc;
 pub mod pmc;

src/cmd/pmc.rs

@@ -16,7 +16,7 @@ pub fn cmd(ec: &mut Ec, args: &[&str]) {
         return;
     }
 
-    let data = match u8::from_str_radix(&args[0], 16) {
+    let data = match u8::from_str_radix(args[0], 16) {
         Ok(ok) => ok,
         Err(err) => {
             eprintln!("argument '{}' failed to parse as hex: {}", args[0], err);
@@ -44,7 +44,7 @@ pub fn write(ec: &mut Ec, args: &[&str]) {
         return;
     }
 
-    let data = match u8::from_str_radix(&args[0], 16) {
+    let data = match u8::from_str_radix(args[0], 16) {
         Ok(ok) => ok,
         Err(err) => {
             eprintln!("argument '{}' failed to parse as hex: {}", args[0], err);

src/main.rs

@@ -29,7 +29,7 @@ struct Completer<'a> {
 impl<'a> liner::Completer for Completer<'a> {
     fn completions(&mut self, start: &str) -> Vec<String> {
         let mut completions = Vec::new();
-        for (name, _func) in self.commands {
+        for name in self.commands.keys() {
             if name.starts_with(start) {
                 completions.push(name.to_string());
             }
@@ -118,7 +118,7 @@ fn commands() -> CommandMap {
                 };
 
                 mcu.xram[addr] = value;
-                
+
                 eprintln!("xram {:04X}: {:02X}", addr, mcu.xram[addr]);
             }
         } else {
@@ -164,9 +164,7 @@ fn timers(ec: &mut Ec) {
 
     // Timer 0 running
     if tcon & 1 << 4 != 0 {
-        if tmod & 0x0F != 0x01 {
-            panic!("unimplemented TMOD 0x{:02X}", tmod);
-        }
+        assert!(tmod & 0x0F == 0x01, "unimplemented TMOD 0x{:02X}", tmod);
 
         if ec.steps % 12 == 0 {
             let tl = 0x8A;
@@ -190,9 +188,7 @@ fn timers(ec: &mut Ec) {
 
     // Timer 1 running
     if tcon & 1 << 6 != 0 {
-        if tmod & 0xF0 != 0x10 {
-            panic!("unimplemented TMOD 0x{:02X}", tmod);
-        }
+        assert!(tmod & 0xF0 == 0x10, "unimplemented TMOD 0x{:02X}", tmod);
 
         if ec.steps % 12 == 0 {
             let tl = 0x8B;
@@ -222,7 +218,7 @@ fn main() {
         RUNNING.store(false, Ordering::SeqCst);
     }).expect("failed to set ctrl-c handler");
 
-    let pmem_path = env::args().nth(1).unwrap_or("ec.rom".to_string());
+    let pmem_path = env::args().nth(1).unwrap_or_else(|| "ec.rom".to_string());
 
     let mut pmem = fs::read(&pmem_path).expect("failed to read ec.rom");
 

src/socket.rs

@@ -98,6 +98,7 @@ pub fn socket_op(ec: &mut Ec, request: &[u8; 4]) -> [u8; 1] {
                 },
                 0x2f => {
                     debug!(" (super io data 0x{:02X})", ec.superio_addr);
+                    #[allow(clippy::match_single_binding)]
                     match ec.superio_addr {
                         _ => {
                             debug!(" (unimplemented)");

src/spi.rs

@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: MIT
 
+#![allow(clippy::needless_range_loop)]
+
 use std::collections::VecDeque;
 
 #[cfg(feature = "debug_spi")]
@@ -20,6 +22,7 @@ pub struct Spi {
     pub output: VecDeque<u8>,
 }
 
+#[allow(clippy::new_without_default)]
 impl Spi {
     pub fn new() -> Self {
         Self {
@@ -31,19 +34,19 @@ impl Spi {
         }
     }
 
-    pub fn step(&mut self, flash: &mut [u8], flash_name: &str) {
+    pub fn step(&mut self, flash: &mut [u8], _flash_name: &str) {
         if let Some(command) = self.input.pop_front() {
-            debug!("\n[spi {}", flash_name);
+            debug!("\n[spi {}", _flash_name);
 
             self.fast_read_addr = None;
 
             match command {
                 0x01 => {
                     debug!(" write status");
 
-                    let value = self.input.pop_front().expect("spi wrate status value missing");
+                    let _value = self.input.pop_front().expect("spi wrate status value missing");
 
-                    debug!(" 0x{:02X}", value);
+                    debug!(" 0x{:02X}", _value);
                 },
                 0x02 => {
                     debug!(" page program");

src/xram.rs

@@ -583,8 +583,8 @@ pub fn xram(ec: &Ec, address: u16, new_opt: Option<u8>) -> u8 {
         // BRAM
         0x2200 ..= 0x22FF => {
             let base = 0x2200;
-            let offset = address - base;
-            debug!(" (BRAM 0x{:02X})", offset);
+            let _offset = address - base;
+            debug!(" (BRAM 0x{:02X})", _offset);
         },
         // PECI
         0x3000 ..= 0x30FF => {
@@ -632,8 +632,8 @@ pub fn xram(ec: &Ec, address: u16, new_opt: Option<u8>) -> u8 {
         },
         0x8000 ..= 0x97FF if ec.id == 0x5570 => {
             let base = 0x8000;
-            let offset = address - base;
-            debug!(" (SRAM 0x{:02X})", offset);
+            let _offset = address - base;
+            debug!(" (SRAM 0x{:02X})", _offset);
         }
         _ => panic!("xram unimplemented register 0x{:04X}", address),
     }