fix(contract): validate role names for stable machine output - #42
Merged
Conversation
Harden the role-name contract so machine-readable surfaces like `status --short` stay predictable. Also: - centralize role-name validation in `src/domain/role.ts` - require role names to match `^[a-z0-9_-]+$` - add `InvalidRoleNameError` with clear user-facing messages - enforce validation in role creation and import - enforce validation on direct role-referencing commands - make invalid persisted role data fail clearly during normalization - add focused CLI and use-case coverage for valid/invalid names - keep `status --short` exact and safe for valid names Verified with: - npm run build - npm test - npm run test:e2e - npm run test:release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the role-name contract so
gitrole’s machine-readable output remains stable and predictable.Changed
src/domain/role.ts^[a-z0-9_-]+$InvalidRoleNameErrorwith clear error messagesgitrole addgitrole import current --name <role>status --shortwork,client-acme, andagent_botstatus --shortoutput for valid role namesVerification
npm run buildnpm testnpm run test:e2enpm run test:releaseNotes