Skip to content

Commit fd13ac8

Browse files
committed
Remove source comments and DocC
1 parent c8c285e commit fd13ac8

17 files changed

Lines changed: 5 additions & 157 deletions

File tree

.github/repro/cross-package/base/Package.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// swift-tools-version: 6.3.3
2-
// Base package for the cross-package debug-info-mangler repro.
3-
// Provides the spec namespace root + the load-bearing namespace TYPEALIAS
4-
// (mirrors swift-pdf-standard's `public typealias PDF = ISO_32000`).
2+
53
import PackageDescription
64

75
let package = Package(

.github/repro/cross-package/base/Sources/BasePDF/BasePDF.swift

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
// Mirrors swift-pdf-standard's namespace shape:
2-
// a spec-named enum namespace re-exposed through a public typealias.
3-
// The typealias is a load-bearing repro ingredient: the existential
4-
// `any PDF.HTML.Style.Modifier` written through it carries TypeAliasType
5-
// sugar at the namespace root, which is what the 6.3.3 Windows (+Asserts)
6-
// debug-info mangler chokes on (isActuallyCanonicalOrNull, AST/Type.h:421).
7-
81
public enum ISO_32000 {}
92

103
extension ISO_32000 {

.github/repro/cross-package/crash/Package.swift

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
// swift-tools-version: 6.3.3
2-
// Crash package for the cross-package debug-info-mangler repro.
3-
// Extends the OTHER package's typealias-sugared namespace with nested
4-
// protocols and forms their existentials at a debug-info-emitting site
5-
// (mirrors swift-pdf-html-render). Cross-PACKAGE is a load-bearing
6-
// ingredient per swiftlang/swift#86202: the same shape cross-module
7-
// within one package does not crash.
2+
83
import PackageDescription
94

105
let package = Package(

.github/repro/cross-package/crash/Sources/CrashModule/CrashModule.swift

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,3 @@
1-
// Mirrors swift-pdf-html-render's crash shape at
2-
// PDF.HTML.Context+Rendering.swift:267/:283:
3-
// - `PDF` below is the OTHER package's typealias for ISO_32000
4-
// (TypeAliasType sugar at the namespace root of every written type here);
5-
// - `HTML`/`Style`/`Style.Context` are enums extending that sugared root;
6-
// - `Modifier` protocols are SE-0404 nested, PLAIN (no ~Copyable, no
7-
// recursion, no associated types);
8-
// - the existentials form via explicit `as? any …` downcasts from `Any`
9-
// whose local bindings receive debug info (-Onone -g).
10-
//
11-
// Expected on Windows Swift 6.3.3 (+Asserts), `swift build -c debug`:
12-
// Assertion failed: isActuallyCanonicalOrNull() &&
13-
// "Forming a CanType out of a non-canonical type!", AST/Type.h:421
14-
// ... While mangling type for debugger type 'any PDF.HTML.Style.Modifier'
15-
161
public import BasePDF
172

183
extension PDF {
@@ -52,7 +37,7 @@ extension PDF.HTML {
5237
}
5338

5439
public mutating func apply(inlineStyle property: Any) -> Bool {
55-
// Unwrap Optional if needed (mirrors the production dataflow).
40+
5641
let unwrapped: Any
5742
let mirror = Mirror(reflecting: property)
5843
if mirror.displayStyle == .optional {

.github/repro/cross-package/crash/Sources/RespellModule/RespellModule.swift

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
// A″ fix-shape validation: IDENTICAL to CrashModule except the two
2-
// existential downcasts (and only those) are respelled through the
3-
// CANONICAL namespace root `ISO_32000` instead of the `PDF` typealias.
4-
// Declarations still extend via the `PDF` alias (declaration parity with
5-
// production). If this target is CLEAN on Windows 6.3.3 while CrashModule
6-
// fires, the typealias sugar in the WRITTEN type at the downcast site is
7-
// the trigger, and the production fix is a one-token respell at
8-
// PDF.HTML.Context+Rendering.swift:267/:283.
9-
101
public import BasePDF
112

123
extension PDF {
@@ -57,7 +48,6 @@ extension PDF.HTML {
5748

5849
var handled = false
5950

60-
// Canonical-root spelling — the only difference from CrashModule.
6151
if let modifier = unwrapped as? any ISO_32000.HTML.Style.Modifier {
6252
modifier.apply(to: &pdf, configuration: configuration)
6353
handled = true

.github/repro/noncanonical-existential-debuginfo.swift

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,3 @@
1-
// Minimal reproducer — Swift 6.3.3 Windows (+Asserts) debug-info-mangler ICE
2-
// on a plain nested-namespace protocol existential.
3-
//
4-
// Classification: ICE (assertion) during IRGen debug-info type mangling.
5-
// Environment: Windows (windows-msvc), Swift 6.3.3 (+Asserts), -Onone -g.
6-
// macOS toolchains are non-asserts; the assertion cannot fire there.
7-
// Command: swiftc -Onone -g -c noncanonical-existential-debuginfo.swift -o repro.o
8-
// Observed: Assertion failed: isActuallyCanonicalOrNull() &&
9-
// "Forming a CanType out of a non-canonical type!", AST/Type.h:421
10-
// while mangling debugger type 'any PDF.HTML.Style.Modifier'.
11-
// Expected: Clean compile.
12-
//
13-
// Shape mirrored from swift-pdf-html-render's PDF.HTML.Context.apply(inlineStyle:)
14-
// (PDF.HTML.Context+Rendering.swift:267/:283): SE-0404 protocols nested in a
15-
// three-level enum namespace, an `Any` value unwrapped via Mirror, then explicit
16-
// `as? any …Modifier` downcasts whose local bindings receive debug info. The
17-
// protocols are PLAIN — no ~Copyable, no recursion, no associated types.
18-
//
19-
// TRACKING: swift-institute/Issues — swift-issue-noncanonical-existential-windows-debuginfo-ice
20-
211
public enum PDF {
222
public enum HTML {
233
public enum Style {
@@ -58,7 +38,7 @@ extension PDF.HTML {
5838
public init() {}
5939

6040
public mutating func apply(inlineStyle property: Any) -> Bool {
61-
// Unwrap Optional if needed (mirrors the production dataflow).
41+
6242
let unwrapped: Any
6343
let mirror = Mirror(reflecting: property)
6444
if mirror.displayStyle == .optional {

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
/Sources/**
2222
!/Sources/**/
2323
!/Sources/**/*.swift
24-
!/Sources/**/*.docc/**
2524
/Tests/**
2625
!/Tests/**/
2726
!/Tests/**/*.swift

Sources/PDF/PDF.docc/PDF.md

Lines changed: 0 additions & 32 deletions
This file was deleted.

Sources/PDF/exports.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// exports.swift
2-
31
@_exported public import File_System
42
@_exported public import HTML
53
@_exported public import Kernel

Tests/PDF Tests/PDF Tests.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// PDF Tests.swift
2-
31
import Foundation
42
import PDF
53
import Testing
@@ -10,8 +8,6 @@ extension PDF {
108
}
119
}
1210

13-
// MARK: - Markdown to PDF Tests
14-
1511
extension PDF.Test.Unit {
1612
@Suite
1713
struct `Markdown to PDF` {

0 commit comments

Comments
 (0)