Skip to content

Commit 6adf38a

Browse files
committed
master: add "use_default_node"
1 parent a928d35 commit 6adf38a

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

common/lib/Munin/Common/Config.pm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ my %legal = map { $_ => 1 } (
4646
"html_rename",
4747
"worker_start_delay",
4848
"num_messages",
49+
"use_default_node",
4950
);
5051

5152
my %bools = map { $_ => 1} qw(yes no true false on off 1 0);

master/lib/Munin/Master/Config.pm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ my %booleans = map {$_ => 1} qw(
124124
tls_verify_certificate
125125
update
126126
use_node_name
127+
use_default_node
127128
);
128129

129130

master/lib/Munin/Master/Node.pm

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ sub _do_connect {
146146
}
147147
};
148148

149+
INFO "node $self->{host} advertised itself as $self->{node_name} instead." if $self->{node_name} && $self->{node_name} ne $self->{host};
150+
149151
return 1;
150152
}
151153

@@ -237,15 +239,20 @@ sub list_plugins {
237239
? $self->{node_name}
238240
: $self->{host};
239241

240-
if (not $host) {
242+
my $use_default_node = defined($self->{configref}{use_default_node})
243+
? $self->{configref}{use_default_node}
244+
: $config->{use_default_node};
245+
246+
if (! $use_default_node && ! $host) {
241247
die "[ERROR] Couldn't find out which host to list on $host.\n";
242248
}
243249

244-
$self->_node_write_single("list $host\n");
250+
my $list_host = $use_default_node ? "" : $host;
251+
$self->_node_write_single("list $list_host\n");
245252
my $list = $self->_node_read_single();
246253

247254
if (not $list) {
248-
WARN "[WARNING] Config node $self->{host} listed no services for $host. Please see http://munin-monitoring.org/wiki/FAQ_no_graphs for further information.";
255+
WARN "[WARNING] Config node $self->{host} listed no services for $host, (advertised as $self->{node_name}). Please see http://munin-monitoring.org/wiki/FAQ_no_graphs for further information.";
249256
}
250257

251258
return split / /, $list;

0 commit comments

Comments
 (0)