SPIR-V generator: return pooled StringBuilders only after use

Author: xen2

sources/shaders/Stride.Shaders.Spirv.Generators/SPVGenerator.EnumerantParams.cs

@@ -44,7 +44,6 @@ public ref partial struct EnumerantParameters
     public static string GenerateImplicitTuples(in EquatableList<string> parameters, in SpirvGrammar grammar)
     {
         var sb = StringBuilderPool.Get();
-        StringBuilderPool.Return(sb);
         if (parameters.AsList() is List<string> { Count: > 0 } paramsList)
         {
             sb.AppendLine(@$"
@@ -77,7 +76,9 @@ public static implicit operator EnumerantParameters(({string.Join(", ", paramsLi
                 }
                 ");
         }
-        return sb.ToString();
+        var result = sb.ToString();
+        StringBuilderPool.Return(sb);
+        return result;
     }
     public static string GenerateImplicitCasting(in OpKind opkind, in SpirvGrammar grammar)
     {
@@ -229,8 +230,9 @@ public static string GenerateEnumerantParameterSingle(in OpKind opkind, in Spirv
 
 
         sb.AppendLine("}");
+        var result = sb.ToString();
         StringBuilderPool.Return(sb);
-        return sb.ToString();
+        return result;
     }
 
 

sources/shaders/Stride.Shaders.Spirv.Generators/SPVGenerator.Instructions.cs

@@ -217,8 +217,9 @@ public void Dispose()
             ");
         }
         structBuilder.AppendLine("}");
+        var result = structBuilder.ToString();
         StringBuilderPool.Return(structBuilder);
-        return structBuilder.ToString();
+        return result;
 
     }
 
@@ -243,8 +244,9 @@ public static string ToSpreadOperators(InstructionData instruction, SpirvGrammar
             }
             else
                 sb.Append(instruction.OpName).Append(", ").Append(string.Join(", ", operands.Select(ToSpreadOperator)));
+            var result = sb.ToString();
             StringBuilderPool.Return(sb);
-            return sb.ToString();
+            return result;
         }
         return instruction.OpName;
     }
@@ -263,8 +265,9 @@ public static string ToAssignSwitchCases(List<OperandData> operands, SpirvGramma
             if (operand.IsParameterized)
                 break;
         }
+        var result = sb.ToString();
         StringBuilderPool.Return(sb);
-        return sb.ToString();
+        return result;
     }
     public static string ToAssignSwitchCase(OperandData operand)
     {
@@ -304,8 +307,9 @@ public static string ToAssignSwitchCase(OperandData operand)
             sb.AppendLine("}");
         sb.Append("break;");
 
+        var result = sb.ToString();
         StringBuilderPool.Return(sb);
-        return sb.ToString();
+        return result;
     }
     public static string ToFunctionParameters(OperandData operand)
     {