[6.x] Fix vite dev for addons - #13241
Merged
Merged
Conversation
it was replacing vue with vue. the resolveId method kicks in early enough anyway in dev mode.
yes its only needed for build mode, but doesn't hurt anything if its also done in dev mode. its just added noise for the pr diff.
apparently because of what we've got in the vite config now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets
npm run devworking for addons.Currently we force
vite build --watch. This isn't necessary anymore.The only requirement is that you're using a CP build that has HMR available. Either:
artisan vendor:publish --tag=statamic-cp-dev) which you should have this anyway if for Vue devtools to work.If you runI've made it so you will see a warning.npm run devand you see an error about__VUE_HMR_RUNTIME__ is not definedwhen saving a file, that's because you aren't doing one of those.Your addon will still compile and work - you'll just need to manually refresh.