[6.x] Narrow stack aesthetics - #13105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current narrow stack variant felt a little floaty to me, so I experimented a little with a couple of designs.
I settled on some simple modifications in the end, adding a header/footer border, which did the trick of adding some separation.
Here are a couple of examples of it in situ:
Tall narrow stack before
Here the title at the top and button actions at the bottom feel like they're floating in space
Tall narrow stack after
Neater after some separation
Small narrow stack before
Small narrow stack after
Extra Detail
I did try this aesthetic but I thought it was too heavy-handed and in the end a lighter touch was better