Skip to content

[6.x] Fix nested revealer fields - #12362

Merged
jasonvarga merged 6 commits into
masterfrom
fix-nested-revealers
Jan 21, 2026
Merged

jasonvarga merged 6 commits into
masterfrom
fix-nested-revealers

Conversation

@duncanmcclean

Copy link
Copy Markdown
Member

This pull request attempts to fix an issue where Revealer fields weren't working in nested fieldtypes like Bard & Replicator.

This was happening because the revealerValues object we're getting from the Container and passing to ShowField looks like this:

{
  replicator.0.revealer: true
}

However, when the field condition validator attempts to get the field's value, it fails, because it's trying to find a value using the revealer's field handle, not its "full dotted path".

This PR fixes it by only passing the "relative" revealer values to ShowField and flattening the keys to just the field handles.

Fixes #12099.

@robdekort

Copy link
Copy Markdown
Contributor

Would love to see this one merged if possible.

@andjsch

andjsch commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

@jasonvarga Any chance this makes it to the next release?

@jasonvarga
jasonvarga merged commit 208c51b into master Jan 21, 2026
11 checks passed
@jasonvarga
jasonvarga deleted the fix-nested-revealers branch January 21, 2026 21:45
@jasonvarga

jasonvarga commented Jan 21, 2026

Copy link
Copy Markdown
Member

This reverts the edge case bug (I've opened in #13622) but we can revisit that when time permits. I'd rather have this out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.x] Revealer field conditions not working with "Toggle" UI mode

4 participants