fix(constants): rename TRANSFER_RESELLER_PRODUCT_ID to TRANSFER_RESELLER_ITEM_SKU and update references

Author: jentyk

adobe_vipm/flows/constants.py

@@ -13,7 +13,7 @@
 )
 from adobe_vipm.flows.errors import ValidationError
 
-TRANSFER_RESELLER_PRODUCT_ID = "adobe-reseller-transfer"
+TRANSFER_RESELLER_ITEM_SKU = "adobe-reseller-transfer"
 
 
 class OrderType(StrEnum):

adobe_vipm/flows/sync/agreement.py

@@ -23,6 +23,7 @@
     TEMPLATE_ASSET_DEFAULT,
     TEMPLATE_SUBSCRIPTION_EXPIRED,
     TEMPLATE_SUBSCRIPTION_TERMINATION,
+    TRANSFER_RESELLER_ITEM_SKU,
     AgreementStatus,
     ItemTermsModel,
     Param,
@@ -564,11 +565,10 @@ def _update_agreement_line_prices(
     def _get_processable_agreement_lines(self, agreement: dict) -> list[tuple[dict, str]]:
         agreement_lines = []
         for line in agreement["lines"]:
-            if line["item"]["externalIds"]["vendor"] != "adobe-reseller-transfer":
+            if line["item"]["externalIds"]["vendor"] != TRANSFER_RESELLER_ITEM_SKU:
                 actual_sku = models.get_adobe_sku(
                     line["item"]["externalIds"]["vendor"], get_market_segment(self.product_id)
                 )
-
                 agreement_lines.append((line, actual_sku))
         return agreement_lines
 

adobe_vipm/flows/validation/transfer.py

@@ -30,6 +30,7 @@
     ERR_ADOBE_UNEXPECTED_ERROR,
     ERR_NO_SUBSCRIPTIONS_WITHOUT_DEPLOYMENT,
     ERR_UPDATING_TRANSFER_ITEMS,
+    TRANSFER_RESELLER_ITEM_SKU,
     Param,
 )
 from adobe_vipm.flows.context import Context
@@ -532,7 +533,7 @@ class AddResellerChangeLinesToOrder(Step):
     def __call__(self, mpt_client, context, next_step):
         """Add lines from reseller change back to the MPT order."""
         reseller_change_item = get_product_items_by_skus(
-            mpt_client, context.order["agreement"]["product"]["id"], ["adobe-reseller-transfer"]
+            mpt_client, context.order["agreement"]["product"]["id"], [TRANSFER_RESELLER_ITEM_SKU]
         )
 
         if not reseller_change_item: