Skip to content

chore: remove 3.6 CI support - #1683

Merged
WilliamBergamin merged 4 commits into
mainfrom
tmp-fix-ci-pipeline
Apr 2, 2025
Merged

chore: remove 3.6 CI support#1683
WilliamBergamin merged 4 commits into
mainfrom
tmp-fix-ci-pipeline

Conversation

@WilliamBergamin

@WilliamBergamin WilliamBergamin commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Summary

The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-15 (actions/runner-images#11101). The next available image is Ubuntu 22.04, but it does not support Python 3.6.

Error: The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04.

The project is in the process of dropping support for python 3.6 until this is done the team will need to manually validate compatibility with python 3.6

Steps:

  1. pyenv shell 3.6.15
  2. python --version -> Python 3.6.15
  3. python -m venv env_3.6.15
  4. source env_3.6.15/bin/activate
  5. scripts/run_validation.sh
  6. No tests fail

Testing

n/a

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added tests M-T: Testing work only dependencies Pull requests that update a dependency file labels Apr 1, 2025
@WilliamBergamin WilliamBergamin self-assigned this Apr 1, 2025
@codecov

codecov Bot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (d4fa653) to head (17da10c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
- Coverage   85.36%   85.32%   -0.04%     
==========================================
  Files         113      113              
  Lines       12808    12808              
==========================================
- Hits        10933    10929       -4     
- Misses       1875     1879       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for keeping main "green" ☑️

I'm somewhat hopeful that using the latest runner might also bring speed improvements to these jobs 🤖 ✨

@hello-ashleyintech hello-ashleyintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you!

@WilliamBergamin
WilliamBergamin merged commit 533ab91 into main Apr 2, 2025
@WilliamBergamin
WilliamBergamin deleted the tmp-fix-ci-pipeline branch April 2, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file tests M-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants