Skip to content

Commit 5d67968

Browse files
committed
MT#61856 update expire rtpe_config object names
So that their naming is self-evident and correlates with the actual options flag: - `media-files-expire` -> `media_files_expire_us` - `db-cache-expire` -> `db_cache_expire_us` - `db-media-expire` -> `db_media_expire_us` Change-Id: I76ebe9f92ba22de7c19fbb2ff47d0bf1952e1480
1 parent c6cfe59 commit 5d67968

3 files changed

Lines changed: 21 additions & 21 deletions

File tree

daemon/main.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -759,9 +759,9 @@ static void options(int *argc, char ***argv, charp_ht templates) {
759759
int final_timeout = 0;
760760
int offer_timeout = 0;
761761
int delete_delay = 30;
762-
int media_expire = 0;
763-
int db_expire = 0;
764-
int cache_expire = 0;
762+
int media_files_expire = 0;
763+
int db_media_expire = 0;
764+
int db_cache_expire = 0;
765765
int rtcp_interval = 0;
766766
int redis_disable_time = 10;
767767
int mqtt_publish_interval = 5000;
@@ -921,15 +921,15 @@ static void options(int *argc, char ***argv, charp_ht templates) {
921921
{ "kernel-player-media",0,0,G_OPTION_ARG_INT, &rtpe_config.kernel_player_media,"Max number of kernel media files","INT"},
922922
{ "preload-media-files",0,0,G_OPTION_ARG_FILENAME_ARRAY,&rtpe_config.preload_media_files,"Preload media file(s) for playback into memory","FILE"},
923923
{ "media-files-reload",0,0,G_OPTION_ARG_INT, &rtpe_config.media_refresh,"Refresh/reload preloaded media files at a certain interval","SECONDS"},
924-
{ "media-files-expire",0,0,G_OPTION_ARG_INT, &media_expire, "Maximum age of unused cached media files","SECONDS"},
924+
{ "media-files-expire",0,0,G_OPTION_ARG_INT, &media_files_expire, "Maximum age of unused cached media files","SECONDS"},
925925
{ "expiry-timer",0,0,G_OPTION_ARG_INT, &rtpe_config.expiry_timer,"How often to check for expired media cache entries","SECONDS"},
926926
{ "preload-db-media",0,0,G_OPTION_ARG_STRING_ARRAY,&rtpe_config.preload_db_media,"Preload media from database for playback into memory","INT"},
927927
{ "db-media-reload",0,0,G_OPTION_ARG_INT, &rtpe_config.db_refresh,"Reload preloaded media from DB at a certain interval","SECONDS"},
928-
{ "db-media-expire",0,0,G_OPTION_ARG_INT, &db_expire, "Maximum age of unused cached DB media entries","SECONDS"},
928+
{ "db-media-expire",0,0,G_OPTION_ARG_INT, &db_media_expire, "Maximum age of unused cached DB media entries","SECONDS"},
929929
{ "db-media-cache",0,0, G_OPTION_ARG_FILENAME, &rtpe_config.db_media_cache,"Directory to store media loaded from database","PATH"},
930930
{ "preload-db-cache",0,0,G_OPTION_ARG_STRING_ARRAY,&rtpe_config.preload_db_cache,"Preload media from database for playback into file cache","INT"},
931931
{ "db-cache-reload",0,0,G_OPTION_ARG_INT, &rtpe_config.cache_refresh,"Refresh/reload cached media from DB at a certain interval","SECONDS"},
932-
{ "db-cache-expire",0,0,G_OPTION_ARG_INT, &cache_expire,"Maximum age of unused cached DB entries in files","SECONDS"},
932+
{ "db-cache-expire",0,0,G_OPTION_ARG_INT, &db_cache_expire,"Maximum age of unused cached DB entries in files","SECONDS"},
933933
{ "audio-buffer-length",0,0, G_OPTION_ARG_INT,&rtpe_config.audio_buffer_length,"Length in milliseconds of audio buffer","INT"},
934934
{ "audio-buffer-delay",0,0, G_OPTION_ARG_INT,&rtpe_config.audio_buffer_delay,"Initial delay in milliseconds for buffered audio","INT"},
935935
{ "audio-player",0,0, G_OPTION_ARG_STRING, &use_audio_player, "When to enable the internal audio player","on-demand|play-media|transcoding|always"},
@@ -1233,16 +1233,16 @@ static void options(int *argc, char ***argv, charp_ht templates) {
12331233
if (rtpe_config.delete_delay_us < 0)
12341234
die("Invalid negative delete-delay");
12351235

1236-
rtpe_config.media_expire_us = media_expire * 1000000LL;
1237-
if (rtpe_config.media_expire_us < 0)
1236+
rtpe_config.media_files_expire_us = media_files_expire * 1000000LL;
1237+
if (rtpe_config.media_files_expire_us < 0)
12381238
die("Invalid negative media-files-expire");
12391239

1240-
rtpe_config.cache_expire_us = cache_expire * 1000000LL;
1241-
if (rtpe_config.cache_expire_us < 0)
1240+
rtpe_config.db_cache_expire_us = db_cache_expire * 1000000LL;
1241+
if (rtpe_config.db_cache_expire_us < 0)
12421242
die("Invalid negative db-cache-expire");
12431243

1244-
rtpe_config.db_expire_us = db_expire * 1000000LL;
1245-
if (rtpe_config.db_expire_us < 0)
1244+
rtpe_config.db_media_expire_us = db_media_expire * 1000000LL;
1245+
if (rtpe_config.db_media_expire_us < 0)
12461246
die("Invalid negative db-media-expire");
12471247

12481248
rtpe_config.rtcp_interval_us = rtcp_interval * 1000LL;

daemon/media_player.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2846,10 +2846,10 @@ unsigned int media_player_evict_player_caches(void) {
28462846

28472847
#ifdef WITH_TRANSCODING
28482848
static void media_player_expire_files(void) {
2849-
if (rtpe_config.media_expire_us <= 0)
2849+
if (rtpe_config.media_files_expire_us <= 0)
28502850
return;
28512851

2852-
int64_t limit = rtpe_now - rtpe_config.media_expire_us;
2852+
int64_t limit = rtpe_now - rtpe_config.media_files_expire_us;
28532853
unsigned int num = 0;
28542854

28552855
{
@@ -2877,10 +2877,10 @@ static void media_player_expire_files(void) {
28772877
}
28782878

28792879
static void media_player_expire_dbs(void) {
2880-
if (rtpe_config.db_expire_us <= 0)
2880+
if (rtpe_config.db_media_expire_us <= 0)
28812881
return;
28822882

2883-
int64_t limit = rtpe_now - rtpe_config.db_expire_us;
2883+
int64_t limit = rtpe_now - rtpe_config.db_media_expire_us;
28842884
unsigned int num = 0;
28852885

28862886
{
@@ -2911,15 +2911,15 @@ static void media_player_expire_cache_entry(unsigned long long id, unsigned int
29112911
int64_t mtime, atime;
29122912
if (!media_player_get_cache_times(id, &mtime, &atime))
29132913
return;
2914-
int64_t limit = rtpe_now - rtpe_config.cache_expire_us; // db-cache-expire
2914+
int64_t limit = rtpe_now - rtpe_config.db_cache_expire_us;
29152915
if (atime >= limit)
29162916
return;
29172917
if (media_player_evict_cache(id))
29182918
(*num)++;
29192919
}
29202920

29212921
static void media_player_expire_caches(void) {
2922-
if (rtpe_config.cache_expire_us <= 0) // db-cache-expire
2922+
if (rtpe_config.db_cache_expire_us <= 0)
29232923
return;
29242924

29252925
unsigned int ret = 0;

include/main.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ enum endpoint_learning {
105105
X(final_timeout_us) \
106106
X(offer_timeout_us) \
107107
X(delete_delay_us) \
108-
X(media_expire_us) \
109-
X(cache_expire_us) \
110-
X(db_expire_us) \
108+
X(media_files_expire_us) \
109+
X(db_cache_expire_us) \
110+
X(db_media_expire_us) \
111111
X(rtcp_interval_us) \
112112
X(redis_disable_time_us) \
113113
X(mqtt_publish_interval_us) \

0 commit comments

Comments
 (0)