Skip to content

Commit 9ef3a11

Browse files
waleedlatif1claude
andcommitted
fix(sap-concur): final live-API alignment
Verified against live SAP Concur docs (concur/developer.concur.com preview branch): - Revert Cash Advance paths to /cashadvance/v4/ (v4.1 endpoints do not exist; live spec is v4) - Travel Profile v2 summary has no Active/Status query param — drop the filter from tool, types, and block - Report Comments v4 contextType is TRAVELER or PROXY only (NOT MANAGER) — move create_report_comment + list_report_comments into the TRAVELER/PROXY context group - Trip v1.1 query keys: userid_type / userid_value / ItemsPerPage / Page (snake/Pascal per docs) — already correct, kept Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 6cc326b commit 9ef3a11

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

apps/docs/content/docs/en/tools/sap_concur.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ Associate attendees with an expense (POST /expensereports/v4/users/\{userId\}/co
9696

9797
### `sap_concur_create_cash_advance`
9898

99-
Create a cash advance (POST /cashadvance/v4.1/cashadvances).
99+
Create a cash advance (POST /cashadvance/v4/cashadvances).
100100

101101
#### Input
102102

@@ -686,7 +686,7 @@ Get a budget item header by ID (GET /budget/v4/budgetItemHeader/\{id\}).
686686

687687
### `sap_concur_get_cash_advance`
688688

689-
Get a cash advance (GET /cashadvance/v4.1/cashadvances/\{cashAdvanceId\}).
689+
Get a cash advance (GET /cashadvance/v4/cashadvances/\{cashAdvanceId\}).
690690

691691
#### Input
692692

@@ -1426,7 +1426,7 @@ Get a single user by UUID (GET /profile/identity/v4.1/Users/\{id\}).
14261426

14271427
### `sap_concur_issue_cash_advance`
14281428

1429-
Issue a cash advance (POST /cashadvance/v4.1/cashadvances/\{cashAdvanceId\}/issue).
1429+
Issue a cash advance (POST /cashadvance/v4/cashadvances/\{cashAdvanceId\}/issue).
14301430

14311431
#### Input
14321432

apps/sim/app/(landing)/integrations/data/integrations.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11666,15 +11666,15 @@
1166611666
},
1166711667
{
1166811668
"name": "Create Cash Advance",
11669-
"description": "Create a cash advance (POST /cashadvance/v4.1/cashadvances)."
11669+
"description": "Create a cash advance (POST /cashadvance/v4/cashadvances)."
1167011670
},
1167111671
{
1167211672
"name": "Get Cash Advance",
11673-
"description": "Get a cash advance (GET /cashadvance/v4.1/cashadvances/{cashAdvanceId})."
11673+
"description": "Get a cash advance (GET /cashadvance/v4/cashadvances/{cashAdvanceId})."
1167411674
},
1167511675
{
1167611676
"name": "Issue Cash Advance",
11677-
"description": "Issue a cash advance (POST /cashadvance/v4.1/cashadvances/{cashAdvanceId}/issue)."
11677+
"description": "Issue a cash advance (POST /cashadvance/v4/cashadvances/{cashAdvanceId}/issue)."
1167811678
},
1167911679
{
1168011680
"name": "List Itineraries (Trips)",

apps/sim/tools/sap_concur/create_cash_advance.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import type { ToolConfig } from '@/tools/types'
99
export const createCashAdvanceTool: ToolConfig<CreateCashAdvanceParams, SapConcurProxyResponse> = {
1010
id: 'sap_concur_create_cash_advance',
1111
name: 'SAP Concur Create Cash Advance',
12-
description: 'Create a cash advance (POST /cashadvance/v4.1/cashadvances).',
12+
description: 'Create a cash advance (POST /cashadvance/v4/cashadvances).',
1313
version: '1.0.0',
1414
params: {
1515
datacenter: {
@@ -67,7 +67,7 @@ export const createCashAdvanceTool: ToolConfig<CreateCashAdvanceParams, SapConcu
6767
headers: () => ({ 'Content-Type': 'application/json' }),
6868
body: (params) => ({
6969
...baseProxyBody(params),
70-
path: `/cashadvance/v4.1/cashadvances`,
70+
path: `/cashadvance/v4/cashadvances`,
7171
method: 'POST',
7272
body: params.body,
7373
}),

apps/sim/tools/sap_concur/get_cash_advance.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import type { ToolConfig } from '@/tools/types'
1010
export const getCashAdvanceTool: ToolConfig<GetCashAdvanceParams, SapConcurProxyResponse> = {
1111
id: 'sap_concur_get_cash_advance',
1212
name: 'SAP Concur Get Cash Advance',
13-
description: 'Get a cash advance (GET /cashadvance/v4.1/cashadvances/{cashAdvanceId}).',
13+
description: 'Get a cash advance (GET /cashadvance/v4/cashadvances/{cashAdvanceId}).',
1414
version: '1.0.0',
1515
params: {
1616
datacenter: {
@@ -70,7 +70,7 @@ export const getCashAdvanceTool: ToolConfig<GetCashAdvanceParams, SapConcurProxy
7070
const cashAdvanceId = trimRequired(params.cashAdvanceId, 'cashAdvanceId')
7171
return {
7272
...baseProxyBody(params),
73-
path: `/cashadvance/v4.1/cashadvances/${encodeURIComponent(cashAdvanceId)}`,
73+
path: `/cashadvance/v4/cashadvances/${encodeURIComponent(cashAdvanceId)}`,
7474
method: 'GET',
7575
}
7676
},

apps/sim/tools/sap_concur/issue_cash_advance.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import type { ToolConfig } from '@/tools/types'
1010
export const issueCashAdvanceTool: ToolConfig<IssueCashAdvanceParams, SapConcurProxyResponse> = {
1111
id: 'sap_concur_issue_cash_advance',
1212
name: 'SAP Concur Issue Cash Advance',
13-
description: 'Issue a cash advance (POST /cashadvance/v4.1/cashadvances/{cashAdvanceId}/issue).',
13+
description: 'Issue a cash advance (POST /cashadvance/v4/cashadvances/{cashAdvanceId}/issue).',
1414
version: '1.0.0',
1515
params: {
1616
datacenter: {
@@ -76,7 +76,7 @@ export const issueCashAdvanceTool: ToolConfig<IssueCashAdvanceParams, SapConcurP
7676
const cashAdvanceId = trimRequired(params.cashAdvanceId, 'cashAdvanceId')
7777
return {
7878
...baseProxyBody(params),
79-
path: `/cashadvance/v4.1/cashadvances/${encodeURIComponent(cashAdvanceId)}/issue`,
79+
path: `/cashadvance/v4/cashadvances/${encodeURIComponent(cashAdvanceId)}/issue`,
8080
method: 'POST',
8181
body: params.body ?? {},
8282
}

0 commit comments

Comments
 (0)