Extract Upsert test

Author: shamcode

tests/data_test.go

@@ -64,11 +64,11 @@ func (c Counters) HasKey(key CounterKey) bool {
 func (c Counters) HasValue(check record.MapValueComparator[uint32]) (bool, error) {
 	for _, item := range c {
 		res, err := check.Compare(item)
-		if nil != err {
-			return false, err
-		}
 
-		if res {
+		switch {
+		case err != nil:
+			return false, err
+		case res:
 			return true, nil
 		}
 	}

tests/simd_test.go

@@ -508,41 +508,6 @@ func Test_InsertAlreadyExisted(t *testing.T) {
 	asserts.Equals(t, "simd: record with passed id already exists: ID == 1", err.Error(), "check error")
 }
 
-func Test_Upsert(t *testing.T) {
-	store := namespace.CreateNamespace[*User]()
-	store.AddIndex(hash.NewComparableHashIndex(userID, true))
-	store.AddIndex(hash.NewComparableHashIndex(userStatus, true))
-	asserts.Success(t, store.Insert(&User{
-		ID:     1,
-		Status: StatusActive,
-	}))
-	asserts.Success(t, store.Insert(&User{
-		ID:     2,
-		Status: StatusDisabled,
-	}))
-	asserts.Success(t, store.Insert(&User{
-		ID:     3,
-		Status: StatusActive,
-	}))
-
-	err := store.Upsert(&User{
-		ID:     2,
-		Status: StatusActive,
-	})
-	asserts.Success(t, err)
-
-	cur, err := executor.CreateQueryExecutor[*User](store).FetchAll(
-		context.Background(),
-		query.NewBuilder[*User](
-			query.Where(userID, where.EQ, 2),
-		).Query(),
-	)
-
-	asserts.Success(t, err)
-	asserts.Success(t, cur.Err())
-	asserts.Equals(t, StatusActive, cur.Item().Status, "status")
-}
-
 func Test_Delete(t *testing.T) {
 	store := namespace.CreateNamespace[*User]()
 	store.AddIndex(hash.NewComparableHashIndex(userID, true))

tests/upsert_test.go

@@ -0,0 +1,50 @@
+package tests
+
+import (
+	"testing"
+
+	asserts "github.com/shamcode/assert"
+	"github.com/shamcode/simd/executor"
+	"github.com/shamcode/simd/indexes/hash"
+	"github.com/shamcode/simd/namespace"
+	"github.com/shamcode/simd/query"
+	"github.com/shamcode/simd/where"
+)
+
+func Test_Upsert(t *testing.T) {
+	// Arrange
+	store := namespace.CreateNamespace[*User]()
+	store.AddIndex(hash.NewComparableHashIndex(userID, true))
+	store.AddIndex(hash.NewComparableHashIndex(userStatus, true))
+	asserts.Success(t, store.Insert(&User{ //nolint:exhaustruct
+		ID:     1,
+		Status: StatusActive,
+	}))
+	asserts.Success(t, store.Insert(&User{ //nolint:exhaustruct
+		ID:     2,
+		Status: StatusDisabled,
+	}))
+	asserts.Success(t, store.Insert(&User{ //nolint:exhaustruct
+		ID:     3,
+		Status: StatusActive,
+	}))
+
+	// Act
+	err := store.Upsert(&User{ //nolint:exhaustruct
+		ID:     2,
+		Status: StatusActive,
+	})
+
+	// Assert
+	asserts.Success(t, err)
+
+	q := query.NewBuilder[*User](
+		query.Where(userID, where.EQ, 2),
+	).Query()
+
+	cur, err := executor.CreateQueryExecutor[*User](store).FetchAll(t.Context(), q)
+
+	asserts.Success(t, err)
+	asserts.Success(t, cur.Err())
+	asserts.Equals(t, StatusActive, cur.Item().Status, "status")
+}