Skip to content

Commit 679895d

Browse files
justin808claude
andcommitted
Fix ESLint default-param-last errors after rebase
After rebasing on master (which merged PR #2097 with parameter order fixes), the ESLint configuration now has the plain 'default-param-last' rule enabled, not the TypeScript version. The buildConsoleReplay function has default params before an optional param (nonce?), which violates the rule. Added block-level eslint-disable comments. The consoleReplay function doesn't violate the rule (all params have defaults), so no disable needed. Fixes CI error: error Default parameters should be last default-param-last 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent b42df93 commit 679895d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/react-on-rails/src/buildConsoleReplay.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ declare global {
1515
* This is useful when you want to wrap the code in script tags yourself (e.g., with a CSP nonce).
1616
* @internal Exported for tests and for Ruby helper to wrap with nonce
1717
*/
18-
// eslint-disable-next-line @typescript-eslint/default-param-last
1918
export function consoleReplay(
2019
customConsoleHistory: (typeof console)['history'] | undefined = undefined,
2120
numberOfMessagesToSkip = 0,
@@ -55,7 +54,7 @@ export function consoleReplay(
5554
return lines.join('\n');
5655
}
5756

58-
// eslint-disable-next-line @typescript-eslint/default-param-last
57+
/* eslint-disable default-param-last */
5958
export default function buildConsoleReplay(
6059
customConsoleHistory: (typeof console)['history'] | undefined = undefined,
6160
numberOfMessagesToSkip = 0,
@@ -67,3 +66,4 @@ export default function buildConsoleReplay(
6766
}
6867
return wrapInScriptTags('consoleReplayLog', consoleReplayJS, nonce);
6968
}
69+
/* eslint-enable default-param-last */

0 commit comments

Comments
 (0)