v3.17.0

Author: rjrodger

CHANGES.md

@@ -1,3 +1,9 @@
+## 3.17.0 2019-10-01
+
+* Fix: use internal.print function fully throughout code base.
+* `close` method waits for one action execution interval before preceding to avoid missing pending actions.
+
+
 ## 3.16.1 2019-09-30
 
 * Option `internal.print.log|err` allows custom printing of console output.

lib/print.js

@@ -59,7 +59,12 @@ module.exports.plugin_options = function plugin_options(
   plugin_options
 ) {
   instance.private$.print.log(
-    '\nSeneca Options (' + instance.id + '): plugin: ' + fullname + '\n' + '===\n'
+    '\nSeneca Options (' +
+      instance.id +
+      '): plugin: ' +
+      fullname +
+      '\n' +
+      '===\n'
   )
   instance.private$.print.log(Util.inspect(plugin_options, { depth: null }))
   instance.private$.print.log('')

lib/ready.js

@@ -25,10 +25,9 @@ function api_ready(ready_func) {
 
   // Allow pending actions to complete
   // TODO: get interval from GateExecutor
-  setTimeout(run_ready,self.private$.ge.options.interval)
-    
-  function run_ready() {
+  setTimeout(run_ready, self.private$.ge.options.interval)
 
+  function run_ready() {
     if ('function' === typeof ready_func) {
       var private$ = self.root.private$
 
@@ -37,11 +36,11 @@ function api_ready(ready_func) {
       }
 
       var ready_name =
-          (null == ready_func.name ||
-           '' === ready_func.name ||
-           'ready' === ready_func.name
-           ? 'ready_'
-           : ready_func.name + '_ready_') + private$.next_ready_id()
+        (null == ready_func.name ||
+        '' === ready_func.name ||
+        'ready' === ready_func.name
+          ? 'ready_'
+          : ready_func.name + '_ready_') + private$.next_ready_id()
 
       Object.defineProperty(ready_call, 'name', { value: ready_name })
 
@@ -52,7 +51,7 @@ function api_ready(ready_func) {
       }
     }
   }
-  
+
   return self
 }
 

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "seneca",
   "description": "A Microservices Framework for Node.js",
-  "version": "3.16.1",
+  "version": "3.17.0",
   "license": "MIT",
   "homepage": "http://senecajs.org",
   "keywords": [

package.json

@@ -11,31 +11,42 @@ const Seneca = require('..')
 
 lab.describe('private', function() {
   lab.test('exit_close', async () => {
-    var tmp = {exit:0}
-    var opts = {system:{exit:()=>{tmp.exit++}}}
+    var tmp = { exit: 0 }
+    var opts = {
+      system: {
+        exit: () => {
+          tmp.exit++
+        }
+      }
+    }
 
-    var si0 = Seneca(opts).use('promisify').test()
+    var si0 = Seneca(opts)
+      .use('promisify')
+      .test()
     si0.private$.exit_close()
     await si0.ready()
     expect(tmp.exit).equal(1)
 
-    
-    var si1 = Seneca(opts).use('promisify').test()
+    var si1 = Seneca(opts)
+      .use('promisify')
+      .test()
     si1.add('role:seneca,cmd:close', function(msg, reply) {
       tmp.si1 = true
-      this.prior(msg,reply)
+      this.prior(msg, reply)
     })
     si1.private$.exit_close()
     await si1.ready()
-    expect(tmp).equal({exit:2,si1:true})
-    
-    var si2 = Seneca(opts).use('promisify').test()
+    expect(tmp).equal({ exit: 2, si1: true })
+
+    var si2 = Seneca(opts)
+      .use('promisify')
+      .test()
     si2.add('role:seneca,cmd:close', function(msg, reply) {
       tmp.si2 = true
       throw new Error('si2')
     })
     si2.private$.exit_close()
     await si2.ready()
-    expect(tmp).equal({exit:3,si1:true,si2:true})
+    expect(tmp).equal({ exit: 3, si1: true, si2: true })
   })
 })

test/private.test.js

@@ -44,7 +44,7 @@ describe('ready', function() {
           fin()
         }
       },
-      
+
       debug: { undead: true }
     })
 

test/ready.test.js

@@ -85,7 +85,7 @@ describe('seneca', function() {
         Package.version +
         '"}'
     )
-    expect(Util.inspect(si).replace(/\n */g,' ')).equal(
+    expect(Util.inspect(si).replace(/\n */g, ' ')).equal(
       "{ isSeneca: true, id: 'a', did: undefined, fixedargs: {}, fixedmeta: undefined, start_time: 123, version: '" +
         Package.version +
         "' }"