Fix code coverage filter not being configured when an extension requires code coverage collection

Author: sebastianbergmann

src/Runner/CodeCoverage.php

@@ -80,7 +80,7 @@ public static function instance(): self
 
     public function init(Configuration $configuration, CodeCoverageFilterRegistry $codeCoverageFilterRegistry, bool $extensionRequiresCodeCoverageCollection): CodeCoverageInitializationStatus
     {
-        $codeCoverageFilterRegistry->init($configuration);
+        $codeCoverageFilterRegistry->init($configuration, $extensionRequiresCodeCoverageCollection);
 
         if (!$configuration->hasCoverageReport() && !$extensionRequiresCodeCoverageCollection) {
             return CodeCoverageInitializationStatus::NOT_REQUESTED;

tests/end-to-end/code-coverage/_files/code-coverage-driver/phpunit-with-extension-that-requires-code-coverage-collection.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="../../../../../phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         cacheDirectory=".phpunit.cache.with-extension-that-requires-code-coverage-collection">
+    <testsuites>
+        <testsuite name="default">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+
+    <source>
+        <include>
+            <file>src/Foo.php</file>
+        </include>
+    </source>
+
+    <coverage driver="PHPUnit\TestFixture\CodeCoverageDriver\CustomDriverWithFakeData"/>
+
+    <extensions>
+        <bootstrap class="PHPUnit\TestFixture\CodeCoverageDriver\ExtensionThatRequiresCodeCoverageCollection"/>
+    </extensions>
+</phpunit>

tests/end-to-end/code-coverage/_files/code-coverage-driver/src/ExtensionThatRequiresCodeCoverageCollection.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\CodeCoverageDriver;
+
+use PHPUnit\Runner\Extension\Extension;
+use PHPUnit\Runner\Extension\Facade;
+use PHPUnit\Runner\Extension\ParameterCollection;
+use PHPUnit\TextUI\Configuration\Configuration;
+
+final class ExtensionThatRequiresCodeCoverageCollection implements Extension
+{
+    public function bootstrap(Configuration $configuration, Facade $facade, ParameterCollection $parameters): void
+    {
+        $facade->requireCodeCoverageCollection();
+
+        $facade->registerSubscriber(new PrintCollectedCodeCoverageSubscriber);
+    }
+}

tests/end-to-end/code-coverage/_files/code-coverage-driver/src/PrintCollectedCodeCoverageSubscriber.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\CodeCoverageDriver;
+
+use const PHP_EOL;
+use function array_keys;
+use function basename;
+use function printf;
+use PHPUnit\Event\TestRunner\ExecutionFinished;
+use PHPUnit\Event\TestRunner\ExecutionFinishedSubscriber;
+use PHPUnit\Runner\CodeCoverage;
+
+final class PrintCollectedCodeCoverageSubscriber implements ExecutionFinishedSubscriber
+{
+    public function notify(ExecutionFinished $event): void
+    {
+        $codeCoverage = CodeCoverage::instance();
+
+        if (!$codeCoverage->isActive()) {
+            print 'code coverage is not being collected' . PHP_EOL;
+
+            return;
+        }
+
+        foreach (array_keys($codeCoverage->codeCoverage()->getData()->lineCoverage()) as $file) {
+            printf(
+                'code coverage was collected for %s%s',
+                basename($file),
+                PHP_EOL,
+            );
+        }
+    }
+}

tests/end-to-end/code-coverage/_files/code-coverage-driver/vendor/autoload.php

@@ -7,3 +7,5 @@
 require __DIR__ . '/../src/CustomDriverWithFilter.php';
 require __DIR__ . '/../src/CustomDriverWithFakeData.php';
 require __DIR__ . '/../src/CustomDriverWithBranchCoverage.php';
+require __DIR__ . '/../src/PrintCollectedCodeCoverageSubscriber.php';
+require __DIR__ . '/../src/ExtensionThatRequiresCodeCoverageCollection.php';

tests/end-to-end/code-coverage/extension-that-requires-code-coverage-collection.phpt

@@ -0,0 +1,28 @@
+--TEST--
+Code coverage is collected for an extension that requires it when no code coverage report is configured
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-record-test-run-history';
+$_SERVER['argv'][] = '--no-progress';
+$_SERVER['argv'][] = '--colors=never';
+$_SERVER['argv'][] = '--configuration';
+$_SERVER['argv'][] = __DIR__ . '/_files/code-coverage-driver/phpunit-with-extension-that-requires-code-coverage-collection.xml';
+
+require __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--CLEAN--
+<?php declare(strict_types=1);
+require __DIR__ . '/../../_files/delete_directory.php';
+
+delete_directory(__DIR__ . '/_files/code-coverage-driver/.phpunit.cache.with-extension-that-requires-code-coverage-collection');
+--EXPECTF--
+PHPUnit %s by Sebastian Bergmann and contributors.
+
+Runtime:       %s with CustomDriverWithFakeData 1.0.0
+Configuration: %s
+
+code coverage was collected for Foo.php
+Time: %s, Memory: %s
+
+OK (1 test, 1 assertion)