Skip to content

Commit c4b70e9

Browse files
author
David Pineau
committed
Allow overriding the ownerCanonicalId in s3curl tests through env
1 parent 3637fc7 commit c4b70e9

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

tests/functional/s3curl/tests.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,22 @@ const aclBucket = 'acluniverse';
2323
const nonexist = 'nonexist';
2424
const prefix = 'topLevel';
2525
const delimiter = '/';
26-
const ownerCanonicalId = '79a59df900b949e55d96a1e698fbacedfd6e09d98eacf8f8d52'
26+
let ownerCanonicalId = '79a59df900b949e55d96a1e698fbacedfd6e09d98eacf8f8d52'
2727
+ '18e7cd47ef2be';
2828
const endpoint = `${transport}://${ipAddress}:8000`;
2929

30+
/*
31+
* XXX TODO FIXME TODO XXX
32+
* The following codeblock aims at improving flexibility of this tests by
33+
* overriding some specific test values from the environment. This is partly
34+
* aimed at re-using this test suite in a different context (end-to-end
35+
* testing rather than functional testing)
36+
* XXX TODO FIXME TODO XXX
37+
*/
38+
if (process.env.S3_TESTVAL_OWNERCANONICALID) {
39+
ownerCanonicalId = process.env.S3_TESTVAL_OWNERCANONICALID;
40+
}
41+
3042
function diff(putFile, receivedFile, done) {
3143
process.stdout.write(`diff ${putFile} ${receivedFile}\n`);
3244
proc.spawn('diff', [putFile, receivedFile]).on('exit', code => {

0 commit comments

Comments
 (0)