This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Use GCC 6 for Node 12 binaries - #2767
Merged
Merged
Conversation
Node 12 is built using GCC 6 therefore it is mandatory that we use the same C++ runtime as the mothership.
xzyfer
approved these changes
Oct 23, 2019
xzyfer
left a comment
xzyfer
left a comment
Contributor
There was a problem hiding this comment.
Seem reasonable if CI is happy.
This was referenced Mar 27, 2020
This was referenced Apr 15, 2020
This was referenced Mar 6, 2021
Closed
Closed
This was referenced Mar 13, 2021
This was referenced Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 12 is built using GCC 6 therefore
it is mandatory that we use the same C++
runtime as the mothership.