rip out TIDY_PRINT_DIFF

and just always show diffs by default.
not sure why you'd want to hide them.

Author: jyn514

src/ci/docker/host-x86_64/tidy/Dockerfile

@@ -39,5 +39,4 @@ COPY host-x86_64/pr-check-1/validate-toolstate.sh /scripts/
 
 # NOTE: intentionally uses python2 for x.py so we can test it still works.
 # validate-toolstate only runs in our CI, so it's ok for it to only support python3.
-ENV SCRIPT="TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
-  src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck"
+ENV SCRIPT="python2.7 ../x.py test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck"

src/etc/pre-push.sh

@@ -33,8 +33,7 @@ ROOT_DIR="$(git rev-parse --show-toplevel)"
 echo "Running pre-push script $ROOT_DIR/x test tidy"
 
 cd "$ROOT_DIR"
-# The env var is necessary for printing diffs in py (fmt/lint) and cpp.
-TIDY_PRINT_DIFF=1 ./x test tidy \
+./x test tidy \
     --set build.locked-deps=true \
     --extra-checks auto:py,auto:cpp,auto:js
 if [ $? -ne 0 ]; then

src/tools/tidy/src/extra_checks/mod.rs

@@ -10,12 +10,11 @@
 //!    configuration after a double dash (`--extra-checks=py -- foo.py`)
 //! 2. Build configuration based on args/environment:
 //!    - Formatters by default are in check only mode
-//!    - If in CI (TIDY_PRINT_DIFF=1 is set), check and print the diff
 //!    - If `--bless` is provided, formatters may run
 //!    - Pass any additional config after the `--`. If no files are specified,
 //!      use a default.
-//! 3. Print the output of the given command. If it fails and `TIDY_PRINT_DIFF`
-//!    is set, rerun the tool to print a suggestion diff (for e.g. CI)
+//! 3. Print the output of the given command. If it fails, rerun the tool to print a suggestion
+//!    diff.
 
 use std::ffi::{OsStr, OsString};
 use std::path::{Path, PathBuf};
@@ -206,12 +205,6 @@ fn show_bless_help(mode: &str, action: &str, bless: bool) {
     }
 }
 
-fn show_diff() -> bool {
-    let disable_diff =
-        std::env::var("TIDY_PRINT_DIFF").is_ok_and(|v| v.eq_ignore_ascii_case("false") || v == "0");
-    !disable_diff
-}
-
 fn check_spellcheck(root_path: &Path, outdir: &Path, cargo: &Path, tidy_ctx: &TidyCtx) {
     let mut check = tidy_ctx.start_check("extra_checks:spellcheck");
 
@@ -318,7 +311,7 @@ fn check_python_lint(
 
     let res = run_ruff(root_path, outdir, py_path, &cfg_args, &file_args, args);
 
-    if res.is_err() && !bless && show_diff() {
+    if res.is_err() && !bless {
         eprintln!("\npython linting failed! Printing diff suggestions:");
 
         let diff_res = run_ruff(
@@ -362,18 +355,16 @@ fn check_python_fmt(
     let res = run_ruff(root_path, outdir, py_path, &cfg_args, &file_args, &args);
 
     if res.is_err() && !bless {
-        if show_diff() {
-            eprintln!("\npython formatting does not match! Printing diff:");
-
-            let _ = run_ruff(
-                root_path,
-                outdir,
-                py_path,
-                &cfg_args,
-                &file_args,
-                &["format".as_ref(), "--diff".as_ref()],
-            );
-        }
+        eprintln!("\npython formatting does not match! Printing diff:");
+
+        let _ = run_ruff(
+            root_path,
+            outdir,
+            py_path,
+            &cfg_args,
+            &file_args,
+            &["format".as_ref(), "--diff".as_ref()],
+        );
         show_bless_help("py:fmt", "reformat Python code", bless);
     }
 
@@ -425,7 +416,7 @@ fn check_cpp_fmt(
     let args = merge_args(&cfg_args_clang_format, &file_args_clang_format);
     let res = py_runner(py_path, false, None, "clang-format", &args);
 
-    if res.is_err() && !bless && show_diff() {
+    if res.is_err() && !bless {
         eprintln!("\nclang-format linting failed! Printing diff suggestions:");
 
         let mut cfg_args_diff = cfg_args.clone();