Apply suggestions from code review

lolbinarycat · Kobzol · web-flow · commit 2dee2a4baeba · 2025-07-28T12:41:04.000-05:00
Co-authored-by: Jakub Beránek &lt;berykubik@gmail.com&gt;
diff --git a/src/tools/tidy/src/lib.rs b/src/tools/tidy/src/lib.rs
@@ -169,7 +169,6 @@ pub fn files_modified_batch_filter<T>(
         None => {
             eprintln!("warning: failed to run `git diff` to check for changes");
             eprintln!("warning: assuming all files are modified");
-            return;
         }
     }
 }
@@ -178,7 +177,7 @@ pub fn files_modified_batch_filter<T>(
 pub fn files_modified(ci_info: &CiInfo, pred: impl Fn(&str) -> bool) -> bool {
     let mut v = vec![()];
     files_modified_batch_filter(ci_info, &mut v, |_, p| pred(p));
-    v.is_empty()
+    !v.is_empty()
 }
 
 pub mod alphabetical;

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,6 @@ pub fn files_modified_batch_filter<T>(`
`169`	`169`	`None => {`
`170`	`170`	eprintln!("warning: failed to run `git diff` to check for changes");
`171`	`171`	`eprintln!("warning: assuming all files are modified");`
`172`		`- return;`
`173`	`172`	`}`
`174`	`173`	`}`
`175`	`174`	`}`
`@@ -178,7 +177,7 @@ pub fn files_modified_batch_filter<T>(`
`178`	`177`	`pub fn files_modified(ci_info: &CiInfo, pred: impl Fn(&str) -> bool) -> bool {`
`179`	`178`	`let mut v = vec![()];`
`180`	`179`	`files_modified_batch_filter(ci_info, &mut v, \|_, p\| pred(p));`
`181`		`- v.is_empty()`
	`180`	`+ !v.is_empty()`
`182`	`181`	`}`
`183`	`182`
`184`	`183`	`pub mod alphabetical;`