[CMake] Add test_tmva_sofie build option

Most of the SOFIE tests require BLAS as a runtime dependency. We need to
make it possible to toggle the TMVA SOFIE tests, so you can switch them
off on platforms where no BLAS is installed or available.

Author: guitargeek

.github/workflows/root-ci-config/buildconfig/global.txt

@@ -68,7 +68,6 @@ roofit_multiprocess=OFF
 root7=ON
 rootbench=OFF
 roottest=ON
-test_roofit_hs3testsuite=ON
 runtime_cxxmodules=ON
 shadowpw=OFF
 shared=ON
@@ -78,6 +77,8 @@ sqlite=ON
 ssl=ON
 test_distrdf_dask=ON
 test_distrdf_pyspark=ON
+test_roofit_hs3testsuite=ON
+test_tmva_sofie=ON
 testing=ON
 tmva-cpu=ON
 tmva-gpu=OFF

.github/workflows/root-ci-config/buildconfig/windows10.txt

@@ -29,6 +29,7 @@ runtime_cxxmodules=OFF
 ssl=OFF
 test_distrdf_dask=OFF
 test_distrdf_pyspark=OFF
+test_tmva_sofie=OFF
 use_gsl_cblas=ON
 vdt=OFF
 x11=OFF

cmake/modules/RootBuildOptions.cmake

@@ -191,6 +191,7 @@ option(minimal "Enable only required options by default" OFF)
 option(rootbench "Build rootbench if rootbench exists in root or if it is a sibling directory (implies testing=ON)" OFF)
 option(roottest "Build roottest (implies testing=ON)" OFF)
 option(test_roofit_hs3testsuite "Setup and use the HS3 conformance test suite (requires network)" OFF)
+option(test_tmva_sofie "Enable SOFIE tests (requires BLAS library that can be found with CMake's FindBLAS)" ON)
 option(testing "Enable testing with CTest" OFF)
 option(asan "Build ROOT with address sanitizer instrumentation (see core/sanitizer for details)" OFF)
 option(_wheel_build "ROOT is being packaged as a wheel, do not install .dist-info metadata" OFF)

cmake/modules/SearchInstalledSoftware.cmake

@@ -1013,16 +1013,14 @@ endif()
 # SOFIE itself has no external dependencies: ONNX models are read with a small
 # self-contained protobuf wire-format decoder (tmva/sofie_parsers/src/onnx.hxx).
 
-if(tmva)
-  if(testing)
-    message(STATUS "Looking for BLAS as an optional testing dependency of TMVA-SOFIE")
-    find_package(BLAS)
-    if(NOT BLAS_FOUND)
-      if(fail-on-missing)
-        message(FATAL_ERROR "BLAS not found, but it's required for TMVA-SOFIE testing")
-      else()
-        message(WARNING "BLAS not found: TMVA-SOFIE will not be fully tested")
-      endif()
+if(tmva AND testing AND test_tmva_sofie)
+  message(STATUS "Looking for BLAS as an optional testing dependency of TMVA-SOFIE")
+  find_package(BLAS)
+  if(NOT BLAS_FOUND)
+    if(fail-on-missing)
+      message(FATAL_ERROR "BLAS not found, but it's required for TMVA-SOFIE testing")
+    else()
+      message(WARNING "BLAS not found: TMVA-SOFIE will not be fully tested")
     endif()
   endif()
 endif()

tmva/sofie/CMakeLists.txt

@@ -109,4 +109,7 @@ if(sofie_root_support)
   target_compile_definitions(ROOTTMVASofie PRIVATE SOFIE_SUPPORT_ROOT_BINARY)
 endif()
 
-ROOT_ADD_TEST_SUBDIRECTORY(test)
+# Tests are not enabled unconditionally because they require BLAS
+if(test_tmva_sofie)
+  ROOT_ADD_TEST_SUBDIRECTORY(test)
+endif()