Skip to content

Commit 0e2f436

Browse files
authored
ci: two scripts for linting with and without fix (#1630)
* ci: two scripts for linting with and without fix * chore: update Changelog
1 parent 4060e78 commit 0e2f436

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/pull_request_template.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ Added `your feature` that allows ...
1818
<!-- Check completed item: [X] -->
1919

2020
- [ ] I have tested this on a device/simulator for each compatible OS
21-
- [ ] I formatted JS and TS files with `yarn lint`
22-
- [ ] I updated the documentation `yarn generate`
21+
- [ ] I formatted JS and TS files with running `yarn lint:fix` in the root folder
22+
- [ ] I updated the documentation with running `yarn generate` in the root folder
2323
- [ ] I mentioned this change in `CHANGELOG.md`
2424
- [ ] I updated the typings files (`index.d.ts`)
2525
- [ ] I added/ updated a sample (`/example`)

.github/workflows/on-push.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ jobs:
2222
run: yarn install --network-timeout 1000000
2323

2424
- name: Lint
25-
run: yarn run lint
25+
run: yarn lint
2626

2727
- name: Test
28-
run: yarn run unittest
28+
run: yarn unittest
2929

3030
- name: Generate
31-
run: yarn run generate
31+
run: yarn generate
3232

3333
outputs:
3434
NVMRC: ${{ steps.nvm.outputs.NVMRC }}

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
Please add unreleased changes in the following style:
55
PR Title ([#123](link to my pr))
66
7+
ci: two scripts for linting with and without fix ([#1630](https://github.com/react-native-mapbox-gl/maps/pull/1630))
78
Update MapLibre to 5.12.1 on iOS ([#1596](https://github.com/react-native-mapbox-gl/maps/pull/1596))
89
Update ShapeSource methods to make it usable with any cluster ( Use cluster itself instead of cluster_id as first argument for getClusterExpansionZoom/getClusterLeaves/getClusterChildren methods. Version < 9 methods still supports passing cluster_id as a first argument but a deprecation warning will be shown. ) ([#1499](https://github.com/react-native-mapbox-gl/maps/pull/1499))
910
fix(Camera) persist zoom when changing from `bounds` to `centerCoordinate`, fix zero padding not causing map to update, create unified example showcasing bounds/centerCoordinate/zoom/padding

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"test": "npm run lint && npm run unittest",
2626
"unittest": "jest",
2727
"unittest:single": "jest --testNamePattern",
28-
"lint": "eslint . --fix",
28+
"lint": "eslint .",
29+
"lint:fix": "eslint . --fix",
2930
"prepare": "yarn build:plugin",
3031
"test:plugin": "expo-module test plugin",
3132
"build:plugin": "tsc --build plugin",

0 commit comments

Comments
 (0)