Move type getter into callback classes

Author: trowski

src/EventLoop/Internal/AbstractDriver.php

@@ -350,7 +350,7 @@ public function __debugInfo(): array
     {
         // @codeCoverageIgnoreStart
         return \array_map(fn (DriverCallback $callback) => [
-            'type' => $this->getType($callback->id),
+            'type' => $callback->getType(),
             'enabled' => $callback->enabled,
             'referenced' => $callback->referenced,
         ], $this->callbacks);
@@ -368,13 +368,7 @@ public function getType(string $callbackId): CallbackType
     {
         $callback = $this->callbacks[$callbackId] ?? throw InvalidCallbackError::invalidIdentifier($callbackId);
 
-        return match ($callback::class) {
-            DeferCallback::class => CallbackType::Defer,
-            TimerCallback::class => $callback->repeat ? CallbackType::Repeat : CallbackType::Delay,
-            StreamReadableCallback::class => CallbackType::Readable,
-            StreamWritableCallback::class => CallbackType::Writable,
-            SignalCallback::class => CallbackType::Signal,
-        };
+        return $callback->getType();
     }
 
     #[\Override]
@@ -395,6 +389,8 @@ public function isReferenced(string $callbackId): bool
 
     /**
      * Activates (enables) all the given callbacks.
+     *
+     * @param array<string, DriverCallback> $callbacks
      */
     abstract protected function activate(array $callbacks): void;
 

src/EventLoop/Internal/DeferCallback.php

@@ -4,7 +4,14 @@
 
 namespace Revolt\EventLoop\Internal;
 
+use Revolt\EventLoop\CallbackType;
+
 /** @internal */
 final class DeferCallback extends DriverCallback
 {
+    #[\Override]
+    public function getType(): CallbackType
+    {
+        return CallbackType::Defer;
+    }
 }

src/EventLoop/Internal/DriverCallback.php

@@ -4,6 +4,8 @@
 
 namespace Revolt\EventLoop\Internal;
 
+use Revolt\EventLoop\CallbackType;
+
 /**
  * @internal
  */
@@ -21,6 +23,8 @@ public function __construct(
     ) {
     }
 
+    abstract public function getType(): CallbackType;
+
     /**
      * @param string $property
      */

src/EventLoop/Internal/SignalCallback.php

@@ -4,6 +4,8 @@
 
 namespace Revolt\EventLoop\Internal;
 
+use Revolt\EventLoop\CallbackType;
+
 /** @internal */
 final class SignalCallback extends DriverCallback
 {
@@ -14,4 +16,10 @@ public function __construct(
     ) {
         parent::__construct($id, $closure);
     }
+
+    #[\Override]
+    public function getType(): CallbackType
+    {
+        return CallbackType::Signal;
+    }
 }

src/EventLoop/Internal/StreamCallback.php

@@ -13,7 +13,7 @@ abstract class StreamCallback extends DriverCallback
     public function __construct(
         string $id,
         \Closure $closure,
-        public readonly mixed $stream
+        public readonly mixed $stream,
     ) {
         parent::__construct($id, $closure);
     }

src/EventLoop/Internal/StreamReadableCallback.php

@@ -4,7 +4,14 @@
 
 namespace Revolt\EventLoop\Internal;
 
+use Revolt\EventLoop\CallbackType;
+
 /** @internal */
 final class StreamReadableCallback extends StreamCallback
 {
+    #[\Override]
+    public function getType(): CallbackType
+    {
+        return CallbackType::Readable;
+    }
 }

src/EventLoop/Internal/StreamWritableCallback.php

@@ -4,7 +4,14 @@
 
 namespace Revolt\EventLoop\Internal;
 
+use Revolt\EventLoop\CallbackType;
+
 /** @internal */
 final class StreamWritableCallback extends StreamCallback
 {
+    #[\Override]
+    public function getType(): CallbackType
+    {
+        return CallbackType::Writable;
+    }
 }

src/EventLoop/Internal/TimerCallback.php

@@ -4,6 +4,8 @@
 
 namespace Revolt\EventLoop\Internal;
 
+use Revolt\EventLoop\CallbackType;
+
 /** @internal */
 final class TimerCallback extends DriverCallback
 {
@@ -12,8 +14,14 @@ public function __construct(
         public readonly float $interval,
         \Closure $callback,
         public float $expiration,
-        public readonly bool $repeat = false
+        public readonly bool $repeat = false,
     ) {
         parent::__construct($id, $callback);
     }
+
+    #[\Override]
+    public function getType(): CallbackType
+    {
+        return $this->repeat ? CallbackType::Repeat : CallbackType::Delay;
+    }
 }