Refactor and convert JS codebase to ESM#6899
Merged
Merged
Conversation
cometkim
force-pushed
the
mordern-js-1
branch
3 times, most recently
from
98fadef to
e7c46ba
Compare
This comment was marked as outdated.
This comment was marked as outdated.
cometkim
force-pushed
the
mordern-js-1
branch
4 times, most recently
from
fecfe13 to
2bb06a1
Compare
cometkim
changed the title
cometkim
force-pushed
the
mordern-js-1
branch
9 times, most recently
from
23b3b44 to
0067a89
Compare
cometkim
force-pushed
the
mordern-js-1
branch
7 times, most recently
from
06b3c80 to
39f16bd
Compare
Co-authored-by: Christoph Knittel <christoph@knittel.cc>
Member
|
Just noticed that this checks in |
Member
Author
|
Thanks, updated the ignore file |
cknitt
reviewed
Mar 29, 2025
cknitt
approved these changes
Mar 29, 2025
fhammerschmidt
pushed a commit
that referenced
this pull request
Apr 4, 2025
Co-authored-by: Christoph Knittel <christoph@knittel.cc>
JonoPrest
added a commit
that referenced
this pull request
May 19, 2026
* super_errors: run fixtures in parallel Each fixture spawns a `bsc` process and the previous `for ... await` loop ran them sequentially, so wall time scaled linearly with fixture count. Replace with a fixed-size worker pool (`os.availableParallelism()` workers) and sort the fixture list for deterministic failure output. Locally on 264 fixtures this cuts the suite from ~2.2s to ~0.9s (~2.4x). The original 2019 implementation was also parallel; the sequential loop was a side-effect of the ESM/async-await refactor in #6899, which explicitly noted it wasn't refactoring tests. * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps:
Required #7354 to use features:
import.meta.dirnameutil.parseArgs(stable)I won't refactor tests here yet.