refactoring changes

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>

Author: msivasubramaniaan

src/extension.ts

@@ -21,7 +21,7 @@ import { getConflictingExtensions, showUninstallConflictsNotification } from './
 import { TelemetryErrorHandler, TelemetryOutputChannel } from './telemetry';
 import { TextDecoder } from 'util';
 import { createJSONSchemaStatusBarItem } from './schema-status-bar-item';
-import { initialize } from './recommendation';
+import { initializeRecommendation } from './recommendation';
 
 export interface ISchemaAssociations {
   [pattern: string]: string[];
@@ -208,7 +208,7 @@ export function startClient(
         createJSONSchemaStatusBarItem(context, client);
       });
 
-      initialize(context);
+      initializeRecommendation(context);
     })
     .catch((err) => {
       sendStartupTelemetryEvent(runtime.telemetry, false, err);

src/recommendation/index.ts

@@ -7,9 +7,9 @@
 
 import * as vscode from 'vscode';
 import { HandlerImpl } from './handlerImpl';
-import { initialize as initDependencyAnalytics } from './dependencyAnalytics';
+import { initializeRecommendation as initOpenShiftToolkit } from './openShiftToolkit';
 
-export function initialize(context: vscode.ExtensionContext): void {
+export function initializeRecommendation(context: vscode.ExtensionContext): void {
   const handler = new HandlerImpl(context);
-  initDependencyAnalytics(context, handler);
+  initOpenShiftToolkit(context, handler);
 }

src/recommendation/dependencyAnalytics.ts src/recommendation/openShiftToolkit.tssrc/recommendation/dependencyAnalytics.ts renamed to src/recommendation/openShiftToolkit.ts

@@ -20,10 +20,10 @@ function isDevfileYAML(uri: vscode.Uri): boolean {
     const devFileYamlPath = path.join(uri.fsPath, 'devfile.yaml');
     return fs.existsSync(devFileYamlPath);
   }
-  return !!uri.path && uri.path.toLowerCase().endsWith('devfile.yaml');
+  return !!uri.path && path.basename(uri.path).toLowerCase() === 'devfile.yaml';
 }
 
-export function initialize(context: vscode.ExtensionContext, handler: IHandler): void {
+export function initializeRecommendation(context: vscode.ExtensionContext, handler: IHandler): void {
   const show = vscode.workspace.getConfiguration().get(YAML_RECOMMENDATIONS_SHOW);
   if (!show) {
     return;