fix(editor): add spacing between items inside of tabs - #1590
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
__tests__/browser/markdown.test.jsOops! Something went wrong! :( ESLint: 8.57.1 Error: Error while loading rule ' Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/Tabs/style.scss`:
- Around line 44-46: Reduce the specificity of the adjacent-sibling selector in
the Tabs stylesheet, preferably by wrapping the full selector in :where(...), so
component-owned margins such as markdown pre and blockquote spacing retain
precedence. Add a regression test covering adjacent components in TabContent
with their own margin-top values.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 80f366e6-d4ac-4182-a208-30a4d9f6b0c2
📒 Files selected for processing (1)
components/Tabs/style.scss
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
readmeio/ai(manual)readmeio/gitto(manual)readmeio/markdown(manual)readmeio/readme(manual)
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@__tests__/browser/markdown.test.js`:
- Around line 74-99: Update the adjacent TabContent spacing test to define
--markdown-spacing as 20px and assert the changed marginBottom property on the
non-final pre or blockquote child, rather than only checking marginTop. Preserve
a separate assertion or test for the 15px fallback if that fallback remains part
of the contract.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 83095804-ae65-498a-8319-4174a11b2925
📒 Files selected for processing (2)
__tests__/browser/markdown.test.jscomponents/Tabs/style.scss
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
readmeio/ai(manual)readmeio/gitto(manual)readmeio/markdown(manual)readmeio/readme(manual)
🚧 Files skipped from review as they are similar to previous changes (1)
- components/Tabs/style.scss
|
🎯 What does this PR do?
🧪 QA tips
<Tab>and confirm there is spacing between them.<Tabs>retain their existing spacing.📸 Screenshot or Loom
Before:

After:
