Commit a9ec420
fix(iOS) [0.74]: RCTRedBox not appearing in Bridgeless when metro is not running (#43147)
Summary:
When testing out `0.74.0-rc0` I found that when the metro is not running we are not displaying RedBox which bumps users to start the packager and reload the app. It also fixes the case where users try to reload by clicking the "Reload" button on RedBox.
## Before
https://github.com/facebook/react-native/assets/52801365/086c557f-ea1f-4a97-b4c7-df8a945cc7a0
## After
https://github.com/facebook/react-native/assets/52801365/9f8421b3-5e83-466f-8cdb-38f97981275d
## Changelog:
[IOS] [FIXED] - RCTRedBox not appearing in Bridgeless when metro is not running
Pull Request resolved: #43147
Test Plan: Build the app without metro running check if RedBox is shown
Reviewed By: javache
Differential Revision: D54632056
Pulled By: dmytrorykun
fbshipit-source-id: fb6742898d3bd82545bfffd9175208e1a5984cb61 parent bd39897 commit a9ec420
2 files changed
Lines changed: 44 additions & 7 deletions
File tree
- packages/react-native
- ReactCommon/react/runtime/platform/ios/ReactCommon
- React/CoreModules
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
277 | | - | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
278 | 284 | | |
279 | 285 | | |
280 | 286 | | |
| |||
Lines changed: 37 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
122 | 124 | | |
123 | 125 | | |
124 | 126 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
129 | 138 | | |
130 | 139 | | |
131 | 140 | | |
| |||
389 | 398 | | |
390 | 399 | | |
391 | 400 | | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
392 | 419 | | |
393 | 420 | | |
394 | 421 | | |
| |||
420 | 447 | | |
421 | 448 | | |
422 | 449 | | |
423 | | - | |
424 | | - | |
| 450 | + | |
425 | 451 | | |
426 | 452 | | |
427 | 453 | | |
| |||
490 | 516 | | |
491 | 517 | | |
492 | 518 | | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
493 | 524 | | |
0 commit comments