Remove internal references of onCatalystInstanceDestroy() (#41835)

Summary:
Pull Request resolved: #41835

This removes internal usages of `onCatalystInstanceDestroy`.

The method is still available inside `NativeModule` but is `Deprecated(forRemoval = true)` so we're getting warning of its usages all over the places.

Changelog:
[Internal] [Changed] - Remove internal references of onCatalystInstanceDestroy()

Reviewed By: hoxyq

Differential Revision: D51589276

fbshipit-source-id: 84ed4d099a444977b95b4ef00e53750b79018e6f

Author: cortinico

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java

@@ -80,17 +80,12 @@ public boolean canOverrideExistingModule() {
     return false;
   }
 
-  @Override
-  public void onCatalystInstanceDestroy() {}
-
   /**
    * The CatalystInstance is going away with Venice. Therefore, the TurboModule infra introduces the
    * invalidate() method to allow NativeModules to clean up after themselves.
    */
   @Override
-  public void invalidate() {
-    onCatalystInstanceDestroy();
-  }
+  public void invalidate() {}
 
   /**
    * Subclasses can use this method to access {@link ReactApplicationContext} passed as a

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapperBase.java

@@ -37,9 +37,6 @@ public boolean canOverrideExistingModule() {
     return false;
   }
 
-  @Override
-  public void onCatalystInstanceDestroy() {}
-
   @Override
   public void invalidate() {
     mHybridData.resetNative();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java

@@ -196,7 +196,7 @@ public void onHostDestroy() {
 
   @Override
   public void invalidate() {
-    super.onCatalystInstanceDestroy();
+    super.invalidate();
     mEventDispatcher.onCatalystInstanceDestroyed();
     mUIImplementation.onCatalystInstanceDestroyed();