This repository was archived by the owner on Feb 8, 2020. It is now read-only.
feat(native-stack): add support for large title attributes - #135
Merged
satya164 merged 3 commits intoOct 21, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 36 36
Lines 752 752
Branches 197 190 -7
=======================================
Hits 704 704
Misses 39 39
Partials 9 9Continue to review full report at Codecov.
|
satya164
suggested changes
Oct 21, 2019
satya164
left a comment
satya164
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Can you update it to use ^ for versions?
Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
Contributor
Author
|
Updated with the suggested changes - thanks @satya164 |
satya164
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR surfaces the
largeTitleFontFamilyandlargeTitleFontSizenow available in react-native-screens 2.0.0-alpha.5