Skip to content

fix(cli-plugin-metro): ensure bundle destination directory exist - #2040

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
tido64:tido/ensure-dest-exists
Aug 9, 2023
Merged

fix(cli-plugin-metro): ensure bundle destination directory exist#2040
thymikee merged 1 commit into
react-native-community:mainfrom
tido64:tido/ensure-dest-exists

Conversation

@tido64

@tido64 tido64 commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Summary:

react-native bundle currently fails if the bundle destination directory does not exist.

Example:

% yarn react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.android.jsbundle --assets-dest dist/res
                Welcome to Metro v0.73.10
              Fast - Scalable - Integrated


info Writing bundle output to:, dist/main.android.jsbundle
error ENOENT: no such file or directory, open 'dist/main.android.jsbundle'.
Error: ENOENT: no such file or directory, open 'dist/main.android.jsbundle'

Test Plan:

Run react-native bundle before and after applying the changes in any app. In my case, I used react-native-test-app.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@tido64
tido64 requested review from adamTrz and thymikee as code owners July 31, 2023 11:07
szymonrybczak
szymonrybczak approved these changes Jul 31, 2023
View reviewed changes

@szymonrybczak szymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee
thymikee merged commit 48d4c29 into react-native-community:main Aug 9, 2023
@tido64
tido64 deleted the tido/ensure-dest-exists branch August 9, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szymonrybczak szymonrybczak szymonrybczak approved these changes
@adamTrz adamTrz Awaiting requested review from adamTrz
@thymikee thymikee Awaiting requested review from thymikee thymikee is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tido64 @szymonrybczak @thymikee