fix: close notification with Enter key#301
Open
MehmetYararVX wants to merge 2 commits into
Open
Conversation
|
@MehmetYararVX is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
yoyo837
reviewed
Mar 1, 2023
| duration: null, | ||
| }); | ||
|
|
||
| setTimeout(() => { |
Contributor
Author
There was a problem hiding this comment.
@yoyo837, all the tests use setTimeout in this test suite, and this test is no different. Not sure this PR is the right place to refactor.
Member
|
strange, why CI not trigger... |
|
@zombieJ Are you able to determine why the workflow wasn't kicked off successfully? |
Member
Could you push some commit to force trigger CI for this? |
Member
|
Hmm... got the reason. Could you help merge into master instead? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #299