Skip to content

feat(FormControl): Add support for html size attribute - #5161

Merged
taion merged 1 commit into
react-bootstrap:masterfrom
Exxenoz:html-size
May 5, 2020
Merged

feat(FormControl): Add support for html size attribute#5161
taion merged 1 commit into
react-bootstrap:masterfrom
Exxenoz:html-size

Conversation

@Exxenoz

@Exxenoz Exxenoz commented May 5, 2020

Copy link
Copy Markdown
Contributor

Description
The commit of this PR adds support for the size attribute of select and input elements. This is especially useful in case someone wants to create a select table with multiple visible options. (Check https://www.w3schools.com/tags/att_select_size.asp for details.)

Changes

  • Added htmlSize prop to FormControl.js and linked it to the size attribute of the underlaying component.
  • Created a new test case in FormControlSpec.js to check if the html size attribute is properly set.
  • Updated forms doc and added an html size example to the "Select" section.

Related issue
#4499

@jquense
jquense requested a review from kosmiq May 5, 2020 13:22
@taion
taion merged commit 1ddd8c7 into react-bootstrap:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants