fix: DropDownItem prop-types active prop (fix: #3598) - #3608
Merged
Conversation
taion
reviewed
Apr 8, 2019
taion
left a comment
taion
left a comment
Member
There was a problem hiding this comment.
i don't think this is quite right... we want to treat false differently from null here
taion
previously approved these changes
Apr 8, 2019
taion
left a comment
taion
left a comment
Member
There was a problem hiding this comment.
this looks good
the one thing i might do naming-wise is – do active: propsActive in destructuring, then call the calculated value active
but that's super nit-picky
taion
approved these changes
Apr 8, 2019
Member
|
should we disable the "automatically dismiss reviews" thing? assuming that was an automatic dismissal |
bpas247
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3598.
I hope it's okay, that I simplified these
== nulland!= nullstatements. (active var type isnull|boolandmakeEventKey() is null|String)