Fix clean method to return Promise always - #3501
Merged
Merged
Conversation
taion
reviewed
Feb 25, 2019
| const esRoot = path.join(libRoot, 'es'); | ||
|
|
||
| const clean = () => fse.existsSync(libRoot) && fse.remove(libRoot); | ||
| const clean = async () => fse.existsSync(libRoot) && fse.remove(libRoot); |
Member
There was a problem hiding this comment.
seems sort of weird... can we just use removeSync here and remove the .then below?
Contributor
Author
There was a problem hiding this comment.
It's also possible. 👍
Contributor
Author
There was a problem hiding this comment.
Let me know if you want. Then I'll fix it.
Member
There was a problem hiding this comment.
let's just do removeSync here and remove the .then below
taion
approved these changes
Feb 27, 2019
jquense
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 79 lines in build.js, it using
.thenmethod. But the current clean method returnsfalse | Promise. So, if there is no lib directory, it throws the above error becauseclean()will returnsfalserather thanPromise<false>.