Skip to content

Commit 263517b

Browse files
JrJuscelinovfraga
authored andcommitted
Improve teste coverage on ArrowDatabaseMatadataTest
1 parent aa49605 commit 263517b

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

java/flight/flight-jdbc-driver/src/test/java/org/apache/arrow/driver/jdbc/ArrowDatabaseMetadataTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import static java.sql.Types.BIGINT;
2323
import static java.sql.Types.BIT;
2424
import static java.sql.Types.INTEGER;
25+
import static java.sql.Types.JAVA_OBJECT;
2526
import static java.util.Collections.singletonList;
2627
import static java.util.stream.Collectors.toList;
2728
import static java.util.stream.IntStream.range;
@@ -1058,6 +1059,9 @@ public void testGetSqlInfo() throws SQLException {
10581059
collector.checkThat(
10591060
metaData.supportsConvert(BIGINT, INTEGER),
10601061
is(EXPECTED_INVALID_SQL_SUPPORTS_CONVERT));
1062+
collector.checkThat(
1063+
metaData.supportsConvert(JAVA_OBJECT, INTEGER),
1064+
is(EXPECTED_INVALID_SQL_SUPPORTS_CONVERT));
10611065
collector.checkThat(metaData.supportsTableCorrelationNames(), is(EXPECTED_SUPPORTS_TABLE_CORRELATION_NAMES));
10621066
collector.checkThat(metaData.supportsDifferentTableCorrelationNames(),
10631067
is(EXPECTED_SUPPORTS_DIFFERENT_TABLE_CORRELATION_NAMES));
@@ -1093,6 +1097,7 @@ public void testGetSqlInfo() throws SQLException {
10931097
is(EXPECTED_TYPE_SCROLL_INSENSITIVE));
10941098
collector.checkThat(metaData.supportsResultSetType(ResultSet.TYPE_SCROLL_SENSITIVE),
10951099
is(EXPECTED_TYPE_SCROLL_SENSITIVE));
1100+
collector.checkThrows(SQLException.class, () -> metaData.supportsResultSetType(ResultSet.HOLD_CURSORS_OVER_COMMIT));
10961101
collector.checkThat(metaData.supportsSelectForUpdate(), is(EXPECTED_SELECT_FOR_UPDATE_SUPPORTED));
10971102
collector.checkThat(metaData.supportsStoredProcedures(), is(EXPECTED_STORED_PROCEDURES_SUPPORTED));
10981103
collector.checkThat(metaData.supportsSubqueriesInComparisons(), is(EXPECTED_SUBQUERIES_IN_COMPARISON));
@@ -1132,6 +1137,8 @@ public void testGetSqlInfo() throws SQLException {
11321137
is(EXPECTED_TRANSACTION_REPEATABLE_READ));
11331138
collector.checkThat(metaData.supportsTransactionIsolationLevel(Connection.TRANSACTION_SERIALIZABLE),
11341139
is(EXPECTED_TRANSACTION_SERIALIZABLE));
1140+
collector.checkThrows(SQLException.class,
1141+
() -> metaData.supportsTransactionIsolationLevel(Connection.TRANSACTION_SERIALIZABLE + 1));
11351142
collector.checkThat(metaData.supportsTransactions(), is(EXPECTED_TRANSACTIONS_SUPPORTED));
11361143
collector.checkThat(metaData.supportsSubqueriesInComparisons(), is(EXPECTED_SUBQUERIES_IN_COMPARISON));
11371144
collector.checkThat(metaData.dataDefinitionCausesTransactionCommit(),

0 commit comments

Comments
 (0)