Skip to content

Commit ec5e3ce

Browse files
d4l-w4rjhchen
authored andcommitted
Fix tab nabbing vulnerability in formatted links
- Add attribute rel="noopener noreferrer" to <a> tags created by formats/link.js - Make unit tests for links expect rel attribute
1 parent cc8526d commit ec5e3ce

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

formats/link.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ class Link extends Inline {
66
let node = super.create(value);
77
value = this.sanitize(value);
88
node.setAttribute('href', value);
9+
node.setAttribute('rel', 'noopener noreferrer');
910
node.setAttribute('target', '_blank');
1011
return node;
1112
}

test/unit/formats/link.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe('Link', function() {
1212
.insert('12', { link: 'https://quilljs.com' })
1313
.insert('3\n')
1414
);
15-
expect(editor.scroll.domNode).toEqualHTML('<p>0<a href="https://quilljs.com" target="_blank">12</a>3</p>');
15+
expect(editor.scroll.domNode).toEqualHTML('<p>0<a href="https://quilljs.com" target="_blank" rel="noopener noreferrer">12</a>3</p>');
1616
});
1717

1818
it('add invalid', function() {
@@ -33,22 +33,22 @@ describe('Link', function() {
3333
.insert('12', { link: Link.SANITIZED_URL })
3434
.insert('3\n')
3535
);
36-
expect(editor.scroll.domNode).toEqualHTML('<p>0<a href="about:blank" target="_blank">12</a>3</p>');
36+
expect(editor.scroll.domNode).toEqualHTML('<p>0<a href="about:blank" target="_blank" rel="noopener noreferrer">12</a>3</p>');
3737
});
3838

3939
it('change', function() {
40-
let editor = this.initialize(Editor, '<p>0<a href="https://github.com" target="_blank">12</a>3</p>');
40+
let editor = this.initialize(Editor, '<p>0<a href="https://github.com" target="_blank" rel="noopener noreferrer">12</a>3</p>');
4141
editor.formatText(1, 2, { link: 'https://quilljs.com' });
4242
expect(editor.getDelta()).toEqual(new Delta()
4343
.insert('0')
4444
.insert('12', { link: 'https://quilljs.com' })
4545
.insert('3\n')
4646
);
47-
expect(editor.scroll.domNode).toEqualHTML('<p>0<a href="https://quilljs.com" target="_blank">12</a>3</p>');
47+
expect(editor.scroll.domNode).toEqualHTML('<p>0<a href="https://quilljs.com" target="_blank" rel="noopener noreferrer">12</a>3</p>');
4848
});
4949

5050
it('remove', function() {
51-
let editor = this.initialize(Editor, '<p>0<a class="ql-size-large" href="https://quilljs.com" target="_blank">12</a>3</p>');
51+
let editor = this.initialize(Editor, '<p>0<a class="ql-size-large" href="https://quilljs.com" target="_blank" rel="noopener noreferrer">12</a>3</p>');
5252
editor.formatText(1, 2, { link: false });
5353
let delta = new Delta().insert('0').insert('12', { size: 'large' }).insert('3\n');
5454
expect(editor.getDelta()).toEqual(delta);

0 commit comments

Comments
 (0)