fixes

Author: mpharrigan

qualtran/bloqs/basic_gates/rotation.py

@@ -43,7 +43,7 @@
 """
 
 from functools import cached_property
-from typing import Callable, Dict, Iterable, Optional, Sequence, Tuple, Type, TYPE_CHECKING, Union
+from typing import Dict, Iterable, Optional, Sequence, Tuple, Type, TYPE_CHECKING, Union
 
 import attrs
 import cirq
@@ -491,8 +491,15 @@ def _rz() -> Rz:
 
 
 def _controlled_rp_circuit(
-    bb: 'BloqBuilder', /, *, single_q_pow_cls: _PowClsT, angle: float, eps: float, ctrl, q
-) -> Dict[str, Soquet]:
+    bb: 'BloqBuilder',
+    /,
+    *,
+    single_q_pow_cls: _PowClsT,
+    angle: SymbolicFloat,
+    eps: SymbolicFloat,
+    ctrl: 'Soquet',
+    q: 'Soquet',
+) -> Dict[str, 'SoquetT']:
     from qualtran.bloqs.basic_gates import CNOT
 
     t = angle / np.pi

qualtran/bloqs/block_encoding/lcu_block_encoding_test.py

@@ -48,7 +48,7 @@ def test_ctrl_lcu_be_cost():
     assert bloq.controlled(CtrlSpec(cvs=0)) == attrs.evolve(bloq, control_val=0)
 
     assert get_cost_value(bloq.controlled(), QECGatesCost()) == GateCounts(
-        cswap=28, and_bloq=77, clifford=294, rotation=16, measurement=77
+        cswap=28, and_bloq=77, clifford=298, rotation=18, measurement=77
     )
 
 

qualtran/serialization/resolver_dict.py

@@ -234,6 +234,7 @@
     "qualtran.bloqs.basic_gates.rotation.Ry": qualtran.bloqs.basic_gates.rotation.Ry,
     "qualtran.bloqs.basic_gates.rotation.Rz": qualtran.bloqs.basic_gates.rotation.Rz,
     "qualtran.bloqs.basic_gates.rotation.CRz": qualtran.bloqs.basic_gates.rotation.CRz,
+    "qualtran.bloqs.basic_gates.rotation.CRy": qualtran.bloqs.basic_gates.rotation.CRy,
     "qualtran.bloqs.basic_gates.rotation.XPowGate": qualtran.bloqs.basic_gates.rotation.XPowGate,
     "qualtran.bloqs.basic_gates.rotation.YPowGate": qualtran.bloqs.basic_gates.rotation.YPowGate,
     "qualtran.bloqs.basic_gates.rotation.ZPowGate": qualtran.bloqs.basic_gates.rotation.ZPowGate,