Skip to content

Commit b1fc120

Browse files
committed
Fix test coverage
1 parent 7fc769a commit b1fc120

3 files changed

Lines changed: 22 additions & 2 deletions

File tree

src/openfermion/linalg/sparse_tools_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1192,6 +1192,11 @@ def test_single_quad_two_mode(self):
11921192
expected = numpy.kron(self.Id, self.p)
11931193
self.assertTrue(numpy.allclose(res, expected))
11941194

1195+
def test_single_quad_op_sparse_invalid_quadrature(self):
1196+
"""Test ValueError for invalid quadrature in single_quad_op_sparse."""
1197+
with self.assertRaisesRegex(ValueError, "Invalid value x for quadrature parameter."):
1198+
single_quad_op_sparse(n_modes=1, mode=0, quadrature='x', hbar=1.0, trunc=2)
1199+
11951200
def test_boson_operator_sparse_trunc(self):
11961201
op = BosonOperator('0')
11971202
with self.assertRaises(ValueError):

src/openfermion/transforms/opconversions/jordan_wigner.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,6 @@ def jordan_wigner_two_body(p, q, r, s, coefficient=1.0):
294294
a, b = p, r
295295
coefficient = -coefficient
296296
c = q
297-
else:
298-
raise RuntimeError('Invalid parameter combination.')
299297

300298
# Get operators.
301299
parity_string = tuple((z, 'Z') for z in range(a + 1, b))

src/openfermion/transforms/opconversions/term_reordering_test.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
from openfermion.transforms.opconversions.term_reordering import (
2525
normal_ordered,
26+
normal_ordered_ladder_term,
2627
chemist_ordered,
2728
reorder,
2829
)
@@ -221,6 +222,22 @@ def test_exceptions(self):
221222
with self.assertRaises(TypeError):
222223
_ = normal_ordered(1)
223224

225+
def test_normal_ordered_ladder_term_invalid_parity(self):
226+
term = ((0, 1), (1, 0))
227+
coefficient = 1.0
228+
invalid_parity_1 = 2
229+
invalid_parity_2 = -2
230+
231+
with self.assertRaisesRegex(
232+
ValueError, f"Invalid value {invalid_parity_1} for parity parameter"
233+
):
234+
normal_ordered_ladder_term(term, coefficient, parity=invalid_parity_1)
235+
236+
with self.assertRaisesRegex(
237+
ValueError, f"Invalid value {invalid_parity_2} for parity parameter"
238+
):
239+
normal_ordered_ladder_term(term, coefficient, parity=invalid_parity_2)
240+
224241

225242
class TestReorder(unittest.TestCase):
226243
def test_reorder(self):

0 commit comments

Comments
 (0)