fix: resolve tsconfig globs relative to tsconfig dir (#455)

TypeScript resolves include/exclude/files patterns relative to the tsconfig
file location, but unplugin-dts passes them to createFilter() which resolves
globs relative to plugin root. When tsconfig is not in the project root, this
mismatch can exclude valid sources and break dts generation.

Convert tsconfig globs to root-relative patterns before creating the filter.
Update vue-vite example to use a solution tsconfig with references.

Co-authored-by: spark <>
Co-authored-by: Rocco <544022268@qq.com>

Author: jdz321

examples/vue-vite/tsconfig.json

@@ -1,31 +1,7 @@
 {
   // test comment
-  "compilerOptions": {
-    "target": "esnext",
-    "module": "esnext",
-    "moduleResolution": "node",
-    "importHelpers": true,
-    "outDir": "dist",
-    "strict": true,
-    "jsx": "preserve",
-    "jsxImportSource": "vue",
-    "allowJs": true,
-    "sourceMap": true,
-    "resolveJsonModule": true,
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "experimentalDecorators": true,
-    "types": [
-      "node",
-      "vite/client"
-    ],
-    "baseUrl": ".",
-    "paths": {
-      "@/*": ["./*"],
-      "@components/*": ["./src/components/*"],
-      "$alias/*": ["./alias/*"]
-    },
-    "lib": ["esnext", "dom"]
-  },
-  "include": ["src", "components", "alias", "*.d.ts"]
+  "files": [],
+  "references": [
+    { "path": "./tsconfig/tsconfig.app.json" }
+  ]
 }

examples/vue-vite/tsconfig/tsconfig.app.json

@@ -0,0 +1,30 @@
+{
+  "compilerOptions": {
+    "target": "esnext",
+    "module": "esnext",
+    "moduleResolution": "node",
+    "importHelpers": true,
+    "outDir": "dist",
+    "strict": true,
+    "jsx": "preserve",
+    "jsxImportSource": "vue",
+    "allowJs": true,
+    "sourceMap": true,
+    "resolveJsonModule": true,
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "experimentalDecorators": true,
+    "types": [
+      "node",
+      "vite/client"
+    ],
+    "baseUrl": "..",
+    "paths": {
+      "@/*": ["./*"],
+      "@components/*": ["./src/components/*"],
+      "$alias/*": ["./alias/*"]
+    },
+    "lib": ["esnext", "dom"]
+  },
+  "include": ["../src", "../components", "../alias", "../*.d.ts"]
+}

examples/vue-vite/vite.config.ts

@@ -34,6 +34,7 @@ export default defineConfig({
   plugins: [
     // @ts-ignore
     dts({
+      tsconfigPath: resolve('./tsconfig/tsconfig.app.json'),
       processor: 'vue',
       copyDtsFiles: true,
       outDirs: [

packages/unplugin-dts/src/core/runtime.ts

@@ -200,12 +200,24 @@ export class Runtime {
         return ensureArray(rootGlobs).map(glob => normalizeGlob(resolveConfigDir(glob, '.')))
       }
 
-      const relativeRoot = configPath
-        ? normalizePath(relative(root, dirname(configPath)).replace(globSignRE, '\\$&'))
-        : '.'
+      // TS globs are relative to tsconfig dir; plugin filter globs are relative to `root`.
+      const relativeRoot = configPath ? normalizePath(relative(root, dirname(configPath))) : '.'
+
+      const relativeRootGlob = relativeRoot === '.' ? '.' : relativeRoot.replace(globSignRE, '\\$&')
+
+      const resolveTsGlobToRoot = (glob: string) => {
+        glob = normalizePath(glob)
+
+        // Keep absolute globs as-is (POSIX + `C:/...`).
+        if (glob.startsWith('/') || /^[a-zA-Z]:\//.test(glob)) return glob
+
+        if (relativeRootGlob === '.') return glob
+
+        return `${relativeRootGlob}/${glob}`
+      }
 
       return ensureArray(tsGlobs?.length ? tsGlobs : defaultGlob).map(glob =>
-        normalizeGlob(resolveConfigDir(glob, relativeRoot)),
+        normalizeGlob(resolveTsGlobToRoot(resolveConfigDir(glob, '.'))),
       )
     }
 
@@ -340,7 +352,14 @@ export class Runtime {
   }
 
   async transform(id: string, code: string) {
-    const { publicRoot, outDirs, resolvers, rootFiles, outputFiles, transformedFiles } = this
+    const {
+      publicRoot,
+      outDirs,
+      resolvers,
+      rootFiles,
+      outputFiles,
+      transformedFiles,
+    } = this
 
     let resolver: Resolver | undefined
     id = normalizePath(id).split('?')[0]
@@ -575,41 +594,34 @@ export class Runtime {
       },
     )
 
-    await runParallel(
-      cpus().length,
-      Array.from(mapFiles.entries()),
-      async ([filePath, content]) => {
-        const baseDir = dirname(filePath)
+    await runParallel(cpus().length, Array.from(mapFiles.entries()), async ([filePath, content]) => {
+      const baseDir = dirname(filePath)
 
-        filePath = resolve(
-          outDir,
-          relative(entryRoot, cleanVueFileName ? filePath.replace('.vue.d.ts', '.d.ts') : filePath),
-        )
-
-        try {
-          const sourceMap: { sources: string[], mappings: string } = JSON.parse(content)
+      filePath = resolve(
+        outDir,
+        relative(entryRoot, cleanVueFileName ? filePath.replace('.vue.d.ts', '.d.ts') : filePath),
+      )
 
-          sourceMap.sources = sourceMap.sources.map(source => {
-            return normalizePath(
-              relative(
-                dirname(filePath),
-                resolve(currentDir, relative(publicRoot, baseDir), source),
-              ),
-            )
-          })
+      try {
+        const sourceMap: { sources: string[], mappings: string } = JSON.parse(content)
 
-          if (prependMappings.has(filePath)) {
-            sourceMap.mappings = `${prependMappings.get(filePath)}${sourceMap.mappings}`
-          }
+        sourceMap.sources = sourceMap.sources.map(source => {
+          return normalizePath(
+            relative(dirname(filePath), resolve(currentDir, relative(publicRoot, baseDir), source)),
+          )
+        })
 
-          content = JSON.stringify(sourceMap)
-        } catch (e) {
-          logger.warn(`${logPrefix} ${yellow('Processing source map fail:')} ${filePath}`)
+        if (prependMappings.has(filePath)) {
+          sourceMap.mappings = `${prependMappings.get(filePath)}${sourceMap.mappings}`
         }
 
-        await writeOutput(filePath, content, outDir)
-      },
-    )
+        content = JSON.stringify(sourceMap)
+      } catch (e) {
+        logger.warn(`${logPrefix} ${yellow('Processing source map fail:')} ${filePath}`)
+      }
+
+      await writeOutput(filePath, content, outDir)
+    })
 
     handleDebug('write output')
 
@@ -621,12 +633,10 @@ export class Runtime {
         pkg = pkgPath && existsSync(pkgPath) ? JSON.parse(await readFile(pkgPath, 'utf-8')) : {}
       } catch (e) {}
 
-      const transformed = new Set(
-        Array.from(transformedFiles).map(file => {
-          file = relative(entryRoot, file)
-          return `${file.replace(tjsRE, '')}.d.${getJsExtPrefix(file)}ts`
-        }),
-      )
+      const transformed = new Set(Array.from(transformedFiles).map(file => {
+        file = relative(entryRoot, file)
+        return `${file.replace(tjsRE, '')}.d.${getJsExtPrefix(file)}ts`
+      }))
 
       const entryNames = Object.keys(entries)
       const types = findTypesPath(pkg.publishConfig, pkg)