Skip to content

Commit 84b518a

Browse files
authored
chore: simplify pinned image lookup (#2897)
Replace the explicit if/else used to resolve pinned container images with pinned_images.get(config_value, config_value) in the manylinux and musllinux loops inside _compute_build_options. This keeps behavior identical while reducing duplication and simplifying the code in cibuildwheel/options.py.
1 parent 785d812 commit 84b518a

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

cibuildwheel/options.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -880,23 +880,15 @@ def _compute_build_options(self, identifier: str | None) -> BuildOptions:
880880
f"manylinux-{build_platform}-image", ignore_empty=True
881881
)
882882
self._check_pinned_image(config_value, pinned_images)
883-
if config_value in pinned_images:
884-
image = pinned_images[config_value]
885-
else:
886-
image = config_value
887-
manylinux_images[build_platform] = image
883+
manylinux_images[build_platform] = pinned_images.get(config_value, config_value)
888884

889885
for build_platform in MUSLLINUX_ARCHS:
890886
pinned_images = all_pinned_container_images[build_platform]
891887
config_value = self.reader.get(
892888
f"musllinux-{build_platform}-image", ignore_empty=True
893889
)
894890
self._check_pinned_image(config_value, pinned_images)
895-
if config_value in pinned_images:
896-
image = pinned_images[config_value]
897-
else:
898-
image = config_value
899-
musllinux_images[build_platform] = image
891+
musllinux_images[build_platform] = pinned_images.get(config_value, config_value)
900892

901893
container_engine_str = self.reader.get(
902894
"container-engine",

0 commit comments

Comments
 (0)