Fix regression for bool fields since 2.13.0 (#784)

Author: hramezani

pydantic_settings/sources/providers/cli.py

@@ -1086,7 +1086,9 @@ def _convert_append_action(self, kwargs: dict[str, Any], field_info: FieldInfo,
     def _convert_bool_flag(self, kwargs: dict[str, Any], field_info: FieldInfo, model_default: Any) -> None:
         if kwargs['metavar'] == 'bool':
             meta_bool_flags = [
-                meta for meta in field_info.metadata if issubclass(meta, _CliImplicitFlag | _CliExplicitFlag)
+                meta
+                for meta in field_info.metadata
+                if isinstance(meta, type) and issubclass(meta, _CliImplicitFlag | _CliExplicitFlag)
             ]
             if not meta_bool_flags and self.cli_implicit_flags:
                 meta_bool_flags = [_CliImplicitFlag]

tests/test_source_cli.py

@@ -2532,6 +2532,19 @@ class WithUnion(BaseSettings):
     assert CliApp.run(WithUnion, ['--poly.type=a']).model_dump() == {'poly': {'a': 1, 'type': 'a'}}
 
 
+def test_cli_bool_with_non_type_metadata():
+    """https://github.com/pydantic/pydantic-settings/issues/782.
+
+    Bool fields with non-type metadata (e.g. CliSuppress) should not crash issubclass.
+    """
+
+    class Settings(BaseSettings):
+        field: CliSuppress[bool] = True
+
+    s = CliApp.run(Settings, cli_args=[])
+    assert s.field is True
+
+
 def test_cli_kebab_case(capsys, monkeypatch):
     class DeepSubModel(BaseModel):
         deep_pos_arg: CliPositionalArg[str]