Merge pull request #1571 from gianlucam76/deployment-errors

(chore) log deployment errors

Author: gianlucam76

controllers/clustersummary_deployer.go

@@ -145,6 +145,9 @@ func (r *ClusterSummaryReconciler) proceedDeployingFeature(ctx context.Context,
 
 	if deployerStatus != nil {
 		logger.V(logs.LogDebug).Info(fmt.Sprintf("deployer result is available: %v", *deployerStatus))
+		if deployerError != nil {
+			logger.V(logs.LogDebug).Error(deployerError, "deployer error")
+		}
 
 		if *deployerStatus == libsveltosv1beta1.FeatureStatusProvisioned {
 			if isPullMode {

controllers/handlers_helm.go

@@ -92,8 +92,6 @@ var (
 )
 
 const (
-	writeFilePermission        = 0644
-	lockTimeout                = 30
 	notInstalledMessage        = "Not installed yet and action is uninstall"
 	defaultMaxHistory          = 2
 	defaultDeletionPropagation = "background"
@@ -183,7 +181,11 @@ func deployHelmCharts(ctx context.Context, c client.Client,
 		return nil
 	}
 
-	return postProcessDeployedHelmCharts(ctx, clusterSummary, kubeconfig, mgmtResources, logger)
+	err = postProcessDeployedHelmCharts(ctx, clusterSummary, kubeconfig, mgmtResources, logger)
+	if err != nil {
+		logger.V(logs.LogInfo).Error(err, "failed to deploy helmCharts")
+	}
+	return err
 }
 
 func postProcessDeployedHelmCharts(ctx context.Context, clusterSummary *configv1beta1.ClusterSummary,
@@ -338,7 +340,11 @@ func undeployHelmCharts(ctx context.Context, c client.Client,
 	}
 	defer closer()
 
-	return undeployHelmChartResources(ctx, c, clusterSummary, kubeconfig, logger)
+	err = undeployHelmChartResources(ctx, c, clusterSummary, kubeconfig, logger)
+	if err != nil {
+		logger.V(logs.LogInfo).Error(err, "failed to undeploy HelmCharts")
+	}
+	return err
 }
 
 func undeployHelmChartsInPullMode(ctx context.Context, c client.Client, clusterSummary *configv1beta1.ClusterSummary,

controllers/handlers_kustomize.go

@@ -130,8 +130,12 @@ func deployKustomizeRefs(ctx context.Context, c client.Client,
 		clusterSummary, logger)
 
 	configurationHash, _ := o.HandlerOptions[configurationHash].([]byte)
-	return processKustomizeDeployment(ctx, remoteRestConfig, clusterSummary, localResourceReports,
+	err = processKustomizeDeployment(ctx, remoteRestConfig, clusterSummary, localResourceReports,
 		remoteResourceReports, deployError, isPullMode, configurationHash, logger)
+	if err != nil {
+		logger.V(logs.LogInfo).Error(err, "failed to deploy KustomizeRefs")
+	}
+	return err
 }
 
 func processKustomizeDeployment(ctx context.Context, remoteRestConfig *rest.Config,

controllers/handlers_resources.go

@@ -86,8 +86,12 @@ func deployResources(ctx context.Context, c client.Client,
 		clusterSummary, featureHandler, logger)
 
 	configurationHash, _ := o.HandlerOptions[configurationHash].([]byte)
-	return postProcessDeployedResources(ctx, remoteRestConfig, clusterSummary, localResourceReports,
+	err = postProcessDeployedResources(ctx, remoteRestConfig, clusterSummary, localResourceReports,
 		remoteResourceReports, deployError, isPullMode, configurationHash, logger)
+	if err != nil {
+		logger.V(logs.LogInfo).Error(err, "failed to deploy PolicyRefs")
+	}
+	return err
 }
 
 func postProcessDeployedResources(ctx context.Context, remoteRestConfig *rest.Config,