Merge pull request #3 from primetheus/feature/async-function-handling

Feature: handle async function hook calls for events

Author: primetheus

src/githubapp/core.py

@@ -5,6 +5,7 @@
 import hmac
 import hashlib
 import requests
+import inspect
 from fastapi import FastAPI, APIRouter, Request, HTTPException, status
 from fastapi.responses import JSONResponse
 from ghapi.all import GhApi
@@ -395,7 +396,7 @@ async def _handle_request(self, request: Request):
         if functions_to_call:
             for function in functions_to_call:
                 try:
-                    result = function()
+                    result = await function() if inspect.iscoroutinefunction(function) else function()
                 except Exception as e:
                     raise HTTPException(
                         status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(e)
@@ -407,4 +408,4 @@ async def _handle_request(self, request: Request):
             )
         return JSONResponse(
             status_code=status.HTTP_200_OK, content={"status": "MISS", "calls": {}}
-        )
+        )

tests/test_core.py

@@ -421,6 +421,37 @@ def test_handler():
             assert data["status"] == STATUS_FUNC_CALLED
             assert "test_handler" in data["calls"]
 
+    def test_handle_request_call_async_hook_function(self):
+        app = FastAPI()
+        github_app = GitHubApp(
+            app,
+            github_app_id=123,
+            github_app_key=b"test_key",
+            github_app_secret=False,  # Disable signature verification for testing
+        )
+        github_app.init_app(app)
+
+        @github_app.on("issues.opened")
+        async def async_test_handler():
+            return "handled"
+
+        with TestClient(app) as client:
+            response = client.post(
+                "/",
+                json={
+                    "action": "opened",
+                    "installation": {"id": 123},
+                    "issue": {"number": 1},
+                },
+                headers={
+                    "Content-Type": "application/json",
+                    "X-GitHub-Event": "issues",
+                },
+            )
+            assert response.status_code == 200
+            data = response.json()
+            assert data["status"] == STATUS_FUNC_CALLED
+            assert "async_test_handler" in data["calls"]
 
 class TestGitHubAppWebhookSignatureVerification:
     def test_signature_verification_disabled(self):