Enhance GCP service account creation logging - #511
Merged
Conversation
- Add comprehensive logging throughout service account creation flow - Add verification step after creating service account to catch propagation issues - Improve error messages with full context (account_id, project, resource names) - Add try-catch blocks in key creation methods for better error handling This helps diagnose issues like the 'service account does not exist' error by logging each step and verifying the account exists before creating keys.
Add test_connection() method to verify GCP IAM API connectivity and permissions. This helps diagnose configuration issues before attempting to create service accounts.
EmmaLouise2018
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Add detailed logging and service account verification - Add comprehensive logging throughout service account creation flow - Add verification step after creating service account to catch propagation issues - Improve error messages with full context (account_id, project, resource names) - Add try-catch blocks in key creation methods for better error handling This helps diagnose issues like the 'service account does not exist' error by logging each step and verifying the account exists before creating keys. * Add connection test method for GCP service account service Add test_connection() method to verify GCP IAM API connectivity and permissions. This helps diagnose configuration issues before attempting to create service accounts.
danf-newton
pushed a commit
to Newton-Research-Inc/salesagent
that referenced
this pull request
Nov 24, 2025
* Add detailed logging and service account verification - Add comprehensive logging throughout service account creation flow - Add verification step after creating service account to catch propagation issues - Improve error messages with full context (account_id, project, resource names) - Add try-catch blocks in key creation methods for better error handling This helps diagnose issues like the 'service account does not exist' error by logging each step and verifying the account exists before creating keys. * Add connection test method for GCP service account service Add test_connection() method to verify GCP IAM API connectivity and permissions. This helps diagnose configuration issues before attempting to create service accounts.
bokelley
referenced
this pull request
in bokelley/salesagent
May 5, 2026
* Add detailed logging and service account verification - Add comprehensive logging throughout service account creation flow - Add verification step after creating service account to catch propagation issues - Improve error messages with full context (account_id, project, resource names) - Add try-catch blocks in key creation methods for better error handling This helps diagnose issues like the 'service account does not exist' error by logging each step and verifying the account exists before creating keys. * Add connection test method for GCP service account service Add test_connection() method to verify GCP IAM API connectivity and permissions. This helps diagnose configuration issues before attempting to create service accounts.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The "404 Service account ... does not exist" error indicates potential issues with service account creation, propagation, or verification. Enhanced logging and verification are needed to pinpoint the root cause.
Changes
src/services/gcp_service_account_service.py:_create_service_accountand_create_service_account_key._verify_service_account_existsto check if a service account exists in GCP post-creation. This is now called after creation with a warning if it fails to avoid blocking on transient issues.try-catchblocks with more comprehensive error context.test_connectionmethod to verify IAM API connectivity and permissions (e.g., ability to list service accounts).Testing
_verify_service_account_existsis called and its output is logged.test_connectionmethod.