Fix X11 maximise glitches

Author: timothyschoen

Source/Standalone/PlugDataWindow.h

@@ -502,7 +502,10 @@ class PlugDataWindow final : public DocumentWindow
 
     bool isMaximised() const
     {
-#if JUCE_LINUX
+#if JUCE_LINUX || JUCE_BSD
+        if (hasPendingLinuxMaximisedState)
+            return pendingLinuxMaximisedState;
+
         if (auto* peer = getPeer()) {
             return OSUtils::isLinuxWindowMaximised(peer);
         } else {
@@ -523,11 +526,12 @@ class PlugDataWindow final : public DocumentWindow
 #if JUCE_LINUX || JUCE_BSD
         if (auto* b = getMaximiseButton()) {
             if (auto* peer = getPeer()) {
-                bool shouldBeMaximised = OSUtils::isLinuxWindowMaximised(peer);
-                b->setToggleState(!shouldBeMaximised, dontSendNotification);
+                bool shouldBeMaximised = !isMaximised();
+                setPendingLinuxMaximisedState(shouldBeMaximised);
+                b->setToggleState(shouldBeMaximised, dontSendNotification);
 
                 if (!useNativeTitlebar()) {
-                    OSUtils::maximiseLinuxWindow(peer, !shouldBeMaximised);
+                    OSUtils::maximiseLinuxWindow(peer, shouldBeMaximised);
                 }
             } else {
                 b->setToggleState(false, dontSendNotification);
@@ -619,6 +623,31 @@ class PlugDataWindow final : public DocumentWindow
     }
 
 private:
+#if JUCE_LINUX || JUCE_BSD
+    void setPendingLinuxMaximisedState(bool shouldBeMaximised)
+    {
+        hasPendingLinuxMaximisedState = true;
+        pendingLinuxMaximisedState = shouldBeMaximised;
+        auto const pendingStateSerial = ++pendingLinuxMaximisedStateSerial;
+
+        Timer::callAfterDelay(250, [_this = SafePointer(this), pendingStateSerial] {
+            if (!_this)
+                return;
+
+            if (_this->pendingLinuxMaximisedStateSerial != pendingStateSerial)
+                return;
+
+            _this->hasPendingLinuxMaximisedState = false;
+
+            if (auto* b = _this->getMaximiseButton())
+                b->setToggleState(_this->isMaximised(), dontSendNotification);
+
+            _this->resized();
+            _this->repaint();
+        });
+    }
+#endif
+
     class MainContentComponent final : public Component
         , private ComponentListener
         , public MenuBarModel {
@@ -784,5 +813,13 @@ class PlugDataWindow final : public DocumentWindow
 public:
     MainContentComponent* mainComponent = nullptr;
 
+private:
+#if JUCE_LINUX || JUCE_BSD
+    bool hasPendingLinuxMaximisedState = false;
+    bool pendingLinuxMaximisedState = false;
+    int pendingLinuxMaximisedStateSerial = 0;
+#endif
+
+public:
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(PlugDataWindow)
 };

Source/Utility/OSUtils.cpp

@@ -286,7 +286,7 @@ bool OSUtils::isLinuxWindowMaximised(ComponentPeer* peer)
         XFree(states);
     }
 
-    return state & WINDOW_STATE_MAXIMIZED;
+    return (state & WINDOW_STATE_MAXIMIZED) != 0;
 }
 
 void OSUtils::maximiseLinuxWindow(ComponentPeer* peer, bool shouldBeMaximised)