@@ -41,8 +41,8 @@ pub const VALID_CATEGORIES: &str = include_str!("categories");
4141
4242#[ derive( Debug , Deserialize , Clone ) ]
4343pub struct BuildAsset {
44- url : String ,
45- out : String ,
44+ pub url : String ,
45+ pub out : String ,
4646}
4747
4848pub struct Linter {
@@ -179,7 +179,7 @@ impl Linter {
179179 pub fn generate_pkgver ( & self , config : & BuildConfig , pkgver_path : & str ) -> bool {
180180 let logger = & self . logger ;
181181 let x_exec = & config. x_exec ;
182- let mut success = true ;
182+ let mut success = false ;
183183
184184 match config. pkgver {
185185 Some ( ref pkgver) => {
@@ -193,6 +193,7 @@ impl Linter {
193193 pkgver,
194194 pkgver_path. bright_cyan( )
195195 ) ) ;
196+ success = true ;
196197 }
197198 None => {
198199 if let Some ( ref pkgver) = x_exec. pkgver {
@@ -214,7 +215,6 @@ impl Linter {
214215 if !cmd. stderr . is_empty ( ) {
215216 logger. error ( "x.exec.pkgver script produced error." ) ;
216217 logger. error ( & String :: from_utf8_lossy ( & cmd. stderr ) ) ;
217- success = false ;
218218 } else {
219219 let out = cmd. stdout ;
220220 let output_str = String :: from_utf8_lossy ( & out) ;
@@ -228,18 +228,17 @@ impl Linter {
228228 output_str. lines ( ) . for_each ( |line| {
229229 logger. info ( & format ! ( "-> {}" , line. trim( ) ) ) ;
230230 } ) ;
231- success = false ;
232231 } else {
233232 let file = File :: create ( pkgver_path) . unwrap ( ) ;
234233 let mut writer = BufWriter :: new ( file) ;
235234 let _ = writer. write_all ( output_str. as_bytes ( ) ) ;
236235
237236 logger. success ( & format ! ( "Fetched version ({}) using x_exec.pkgver written to {}" , & output_str, pkgver_path. bright_cyan( ) ) ) ;
237+ success = true ;
238238 }
239239 }
240240 } else {
241241 logger. error ( & format ! ( "{} -> Failed to read output from pkgver script. Please make sure the script is valid." , "x_exec.pkgver" . bold( ) ) ) ;
242- success = false ;
243242 if !cmd. stderr . is_empty ( ) {
244243 logger. error ( & String :: from_utf8_lossy ( & cmd. stderr ) ) ;
245244 }
@@ -251,7 +250,6 @@ impl Linter {
251250 "x_exec.pkgver" . bold( ) ,
252251 err
253252 ) ) ;
254- success = false ;
255253 }
256254 }
257255 }
@@ -260,11 +258,13 @@ impl Linter {
260258 "{} -> pkgver script timed out after 15 seconds" ,
261259 "x_exec.pkgver" . bold( )
262260 ) ) ;
263- success = false ;
264261 }
265262 }
266263
267264 fs:: remove_file ( tmp) . expect ( "Failed to delete temporary script file" ) ;
265+ } else {
266+ // we don't care if the pkgver is not set
267+ success = true ;
268268 }
269269 }
270270 }
0 commit comments