Upgrade to Cake 5.0

Using rector
And applying https://github.com/cakephp/app/blob/5.x/composer.json

Author: williamdes

composer.json

@@ -20,18 +20,18 @@
     "require": {
         "php": "^8.4",
         "ext-curl": "*",
-        "cakephp/cakephp": "^4.6",
-        "cakephp/migrations": "^3.0.0",
-        "cakephp/plugin-installer": "^1.3",
+        "cakephp/cakephp": "5.3.*",
+        "cakephp/migrations": "^5.0",
+        "cakephp/plugin-installer": "^2.0",
         "composer/ca-bundle": "^1.3"
     },
     "require-dev": {
-        "cakephp/bake": "^2.1.1",
-        "cakephp/debug_kit": "^4.1.2",
+        "cakephp/bake": "^3.6",
+        "cakephp/debug_kit": "^5.2",
         "php-mock/php-mock-phpunit": "^2.6",
         "phpmyadmin/coding-standard": "^3",
         "phpstan/phpstan": "^2",
-        "phpunit/phpunit": "^9",
+        "phpunit/phpunit": "^13.0",
         "psy/psysh": "@stable"
     },
     "autoload": {

src/Controller/AppController.php

@@ -156,9 +156,7 @@ public function beforeFilter(EventInterface $event)
 
             $notif_count = TableRegistry::getTableLocator()->get('Notifications')->find(
                 'all',
-                [
-                    'conditions' => ['developer_id' => (int) isset($current_developer) ? $current_developer['id'] : null],
-                ]
+                conditions: ['developer_id' => (int) isset($current_developer) ? $current_developer['id'] : null]
             )->count();
             $this->set('current_developer', $current_developer);
             $this->set('developer_signed_in', true);

src/Controller/GithubController.php

@@ -509,11 +509,9 @@ public function sync_issue_status(): void
         // Fetch all linked reports
         $reports = $reportsTable->find(
             'all',
-            [
-                'conditions' => [
-                    'sourceforge_bug_id IS NOT NULL',
-                    'NOT' => ['status' => 'resolved'],
-                ],
+            conditions: [
+                'sourceforge_bug_id IS NOT NULL',
+                'NOT' => ['status' => 'resolved'],
             ]
         );
 

src/Controller/NotificationsController.php

@@ -105,10 +105,8 @@ public function data_tables(): Response
         $rows = $this->Notifications->find('all', $pagedParams);
         $totalFiltered = $this->Notifications->find(
             'all',
-            [
-                'conditions' => [
-                    'developer_id' => $current_developer['id'],
-                ],
+            conditions: [
+                'developer_id' => $current_developer['id'],
             ]
         )->count();
 

src/Controller/PagesController.php

@@ -40,10 +40,8 @@ class PagesController extends AppController
 {
     /**
      * Controller name.
-     *
-     * @var string
      */
-    public $name = 'Pages';
+    public string $name = 'Pages';
 
     /**
      * Displays a view.

src/Controller/ReportsController.php

@@ -87,10 +87,11 @@ public function index(): void
         );
         $this->set(
             'distinct_error_names',
-            $this->findArrayList($this->Reports->find('all', [
-                'fields' => ['error_name'],
-                'conditions' => ['error_name !=' => ''],
-            ])->distinct(['error_name']), 'error_name')
+            $this->findArrayList($this->Reports->find(
+                'all',
+                fields: ['error_name'],
+                conditions: ['error_name !=' => '']
+            )->distinct(['error_name']), 'error_name')
         );
         $this->set('statuses', $this->Reports->status);
         $this->autoRender = true;

src/Model/Table/ReportsTable.php

@@ -89,11 +89,12 @@ public function initialize(array $config): void
      */
     public function getIncidents(): Query
     {
-        return TableRegistry::getTableLocator()->get('Incidents')->find('all', [
-            'limit' => 50,
-            'conditions' => $this->relatedIncidentsConditions(),
-            'order' => 'Incidents.created desc',
-        ]);
+        return TableRegistry::getTableLocator()->get('Incidents')->find(
+            'all',
+            limit: 50,
+            conditions: $this->relatedIncidentsConditions(),
+            order: 'Incidents.created desc'
+        );
     }
 
     /**
@@ -103,9 +104,7 @@ public function getIncidents(): Query
      */
     public function getRelatedReports(): Query
     {
-        return $this->find('all', [
-            'conditions' => $this->relatedReportsConditions(),
-        ]);
+        return $this->find('all', conditions: $this->relatedReportsConditions());
     }
 
     /**
@@ -116,13 +115,14 @@ public function getRelatedReports(): Query
      */
     public function getIncidentsWithDescription(): Query
     {
-        return TableRegistry::getTableLocator()->get('Incidents')->find('all', [
-            'conditions' => [
+        return TableRegistry::getTableLocator()->get('Incidents')->find(
+            'all',
+            conditions: [
                 'NOT' => ['Incidents.steps is null'],
                 $this->relatedIncidentsConditions(),
             ],
-            'order' => 'Incidents.steps desc',
-        ]);
+            order: 'Incidents.steps desc'
+        );
     }
 
     /**
@@ -133,16 +133,17 @@ public function getIncidentsWithDescription(): Query
      */
     public function getIncidentsWithDifferentStacktrace(): Query
     {
-        return TableRegistry::getTableLocator()->get('Incidents')->find('all', [
-            'fields' => [
+        return TableRegistry::getTableLocator()->get('Incidents')->find(
+            'all',
+            fields: [
                 'Incidents.stackhash',
                 'Incidents.stacktrace',
                 'Incidents.full_report',
                 'Incidents.exception_type',
             ],
-            'conditions' => $this->relatedIncidentsConditions(),
-            'group' => 'Incidents.stackhash',
-        ])->distinct(['Incidents.stackhash']);
+            conditions: $this->relatedIncidentsConditions(),
+            group: 'Incidents.stackhash'
+        )->distinct(['Incidents.stackhash']);
     }
 
     /**
@@ -265,8 +266,8 @@ public function getRelatedByField(
         $groupedCount->select([
             'count' => $groupedCount->func()->count('*'),
             $fieldAlias => $field,
-        ])->group($fieldAlias)->distinct(['' . $fieldAlias . ''])
-          ->order('count')->toArray();
+        ])->groupBy($fieldAlias)->distinct(['' . $fieldAlias . ''])
+          ->orderBy('count')->toArray();
 
         if ($count) {
             $queryDetails['fields'] = ['' . $fieldName . ''];

src/Shell/CleanOldNotifsShell.php

@@ -67,7 +67,7 @@ public function execute(Arguments $args, ConsoleIo $io)
         $XTime = time() - 60 * 24 * 3600;
         $conditions = ['Notifications.created <' => date('Y-m-d H:i:s', $XTime)];
 
-        if ($this->Notifications->find('all', ['conditions' => $conditions])->count() === 0) {
+        if ($this->Notifications->find('all', conditions: $conditions)->count() === 0) {
             // Check if there are any notifications to delete
             Log::write(
                 'info',

src/View/Helper/ReportsHelper.php

@@ -14,7 +14,7 @@
 class ReportsHelper extends AppHelper
 {
     /** @var string */
-    public $helpers = ['Incidents'];
+    public array $helpers = ['Incidents'];
 
     /**
      * @param array[] $entries    Entries