zend_compile: Fix incorrect use of ZVAL_NEW_STR() in zend_compile_call() (#21851)

TimWolla · web-flow · commit eafc26784d92 · 2026-04-23T19:21:27.000+02:00
`zend_string_tolower()` might return the original string when it's already
fully lowercase.
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -5203,7 +5203,7 @@ static void zend_compile_call(znode *result, zend_ast *ast, uint32_t type) /* {{
 		}
 
 		zval_ptr_dtor(&name_node.u.constant);
-		ZVAL_NEW_STR(&name_node.u.constant, lcname);
+		ZVAL_STR(&name_node.u.constant, lcname);
 
 		opline = zend_emit_op(NULL, ZEND_INIT_FCALL, NULL, &name_node);
 		opline->result.num = zend_alloc_cache_slot();

Original file line number	Diff line number	Diff line change
`@@ -5203,7 +5203,7 @@ static void zend_compile_call(znode result, zend_ast ast, uint32_t type) /* {{`
`5203`	`5203`	`}`
`5204`	`5204`
`5205`	`5205`	`zval_ptr_dtor(&name_node.u.constant);`
`5206`		`- ZVAL_NEW_STR(&name_node.u.constant, lcname);`
	`5206`	`+ ZVAL_STR(&name_node.u.constant, lcname);`
`5207`	`5207`
`5208`	`5208`	`opline = zend_emit_op(NULL, ZEND_INIT_FCALL, NULL, &name_node);`
`5209`	`5209`	`opline->result.num = zend_alloc_cache_slot();`